8000 [GraphBolt] Remove workaround for `DILL_AVAILABLE` in torch 2.3.0 · Issue #7387 · dmlc/dgl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[GraphBolt] Remove workaround for DILL_AVAILABLE in torch 2.3.0 #7387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Rhett-Ying opened this issue May 9, 2024 · 5 comments
Closed

[GraphBolt] Remove workaround for DILL_AVAILABLE in torch 2.3.0 #7387

Rhett-Ying opened this issue May 9, 2024 · 5 comments
Assignees
@Skeleton003
Labels
Release Blocker Issues that blocks release Work Item Work items tracked in project tracker

Comments

@Rhett-Ying
Copy link
Collaborator

🔨Work Item

IMPORTANT:

  • This template is only for dev team to track project progress. For feature request or bug report, please use the corresponding issue templates.
  • DO NOT create a new work item if the purpose is to fix an existing issue or feature request. We will directly use the issue in the project tracker.

Project tracker: DGL Project Tracker

Description

Depending work items or issues
@Rhett-Ying Rhett-Ying added the Work Item Work items tracked in project tracker label May 9, 2024
@Rhett-Ying
Copy link
Collaborator Author

see #7383

@mfbalin
Copy link
Collaborator
mfbalin commented May 15, 2024 •
edited
Loading

pytorch/pytorch#125425 (comment)

Looks like the fix will be available in 2.3.1.

@mfbalin
Copy link
Collaborator
mfbalin commented May 31, 2024

pytorch/pytorch#124907 (comment)

@Rhett-Ying
Copy link
Collaborator Author

back-compatible is available since torch 2.3.1. we should make change on current workaround in DGL:

dgl/python/dgl/graphbolt/base.py

Lines 9 to 16 in 7c3d418

if TorchVersion(torch.__version__) >= "2.3.0":
# [TODO][https://github.com/dmlc/dgl/issues/7387] Remove or refine below
# check.
# Due to https://github.com/dmlc/dgl/issues/7380, we need to check if dill
# is available before using it.
torch.utils.data.datapipes.utils.common.DILL_AVAILABLE = (
torch.utils._import_utils.dill_available()
)

@Rhett-Ying Rhett-Ying added the Release Blocker Issues that blocks release label Jun 20, 2024
@mfbalin
Copy link
Collaborator
mfbalin commented Jul 18, 2024

Fixed by #7474.

@mfbalin mfbalin closed this as completed Jul 18, 2024
@SarahAlidoost SarahAlidoost mentioned this issue Aug 1, 2024
Closed
@SarahAlidoost SarahAlidoost mentioned this issue Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skeleton003 Skeleton003

Labels
Release Blocker Issues that blocks release Work Item Work items tracked in project tracker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mfbalin @Rhett-Ying @Skeleton003
0