8000 deployment announcement does not properly handle double quotes · Issue #277 · djoos-cookbooks/newrelic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

deployment announcement does not properly handle double quotes #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
olbrich opened this issue Nov 9, 2016 · 0 comments
Open

deployment announcement does not properly handle double quotes #277

olbrich opened this issue Nov 9, 2016 · 0 comments

Comments

@olbrich
Copy link
olbrich commented Nov 9, 2016

https://github.com/djoos-cookbooks/newrelic/blob/master/providers/deployment.rb#L78

This line of code does not do what it intends to do.

It looks like the intent of this is to escape double quotes in the deploy message, but tr doesn't work properly for this.

puts %Q(").tr('"','\"') #=> "

it should probably be

string.gsub('"','\"')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olbrich
0