Replies: 2 comments
-
|
Not 100% sure what you mean about converting all keys to constants, could you show an example? Since you can set a permission via And yeah, ideally we match the Discord documentation, however I am weary of making this a breaking change. We should be able to add the correct name alongside the old name to keep backwards compatibility, just leaving a note of which one is deprecated. e.g. |
Beta Was this translation helpful? Give feedback.
-
|
The problem I see lies in those string literal indices: Nothing critical here of course, just good old refactoring. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I think it makes sense to convert all Permission keys https://github.com/discord-php/DiscordPHP/blob/master/src/Discord/Parts/Permissions/Permission.php#L35 to constants. Also it would make more sense to rename these Permission keys to their Discord-documented counterparts snake-cased (e.g.
use_slash_commandsshould becomeuse_application_commandsetc) https://discord.com/developers/docs/topics/permissions . I can send in PR. Thoughts?Beta Was this translation helpful? Give feedback.
All reactions