8000 Production / hardened webserver images no longer include git or ssh · Issue #7054 · ddev/ddev · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Production / hardened webserver images no longer include git or ssh #7054
Closed
@deviantintegral

Description

@deviantintegral

Preliminary checklist

Output of ddev debug test

Not debug test but I don't think that's useful in this case anyways!

❯ docker run --rm  ddev/ddev-webserver-prod:v1.24.3 which git
/usr/bin/git
❯ docker run --rm  ddev/ddev-webserver-prod:v1.24.3 which ssh
exit status 1
❯ docker run --rm  ddev/ddev-webserver-prod:v1.24.0 which ssh
/usr/bin/ssh

Expected Behavior

ssh is available so git can work.

Actual Behavior

Cloning into '/tmp/tmp.JkH5ATrbRF'...
error: cannot run ssh: No such file or directory
fatal: unable to fork
Cloning into '/tmp/tmp.JkH5ATrbRF'...
error: cannot run ssh: No such file or directory
fatal: unable to fork

Steps To Reproduce

  1. Turn on hardened images (in our case, we're using ddev config global --use-hardened-images in CI as it's a faster download).
  2. Try to do git clone with an SSH remote. In our case, we need that to be able to pull a repository down from Pantheon and then later push back up to it.

Anything else?

#6839 (review) suggested removing both git and ssh, but in practice git was left in. It seems like either:

  1. git should be removed, because it is not that useful without ssh.
  2. ssh should be added back in.
  3. Even if nothing changes, can we update the release notes? It wasn't clear from me scanning them that the above PR touched the hardened images - I only figured it out by running git log -S -p ssh locally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0