-
-
Notifications
You must be signed in to change notification settings - Fork 31
Blog: Manually managing tool versions and adding custom utilities #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just a note: Please use a meaningful branch name (not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely needs to lead with the problem at hand (terminus downgrade) and that needs to be added to the title as well.
Changes applied! I'll remember the tip for branching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming along great, thanks for doing this!
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Pushed some changes, please review. Thanks for holding my hand in this one |
On my list, thanks! If you get a chance also try to fix the test failure (should be easy, hints on lint fixes in the README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this! I'll see if I can clear up the linting failures.
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks! I fixed the prettier linting complaint so do a git pull if editing locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Co-authored-by: tyler36 <tyler36@users.noreply.github.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Thanks all for the review, and the help on English language! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, thanks!
The Issue
Blog about manually managing installed software in ddev
How This PR Solves The Issue
Provides the article
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
ddev/ddev#7352
Release/Deployment Notes