10000 Event's occurredOn attributes types should be immutable · Issue #20 · dddshelf/ddd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Event's occurredOn attributes types should be immutable #20
Open
@bystro

Description

@bystro

First of all I want to thank you boys for your job. I bought your e-book and find it useful.

Event's occurredOn attributes types should be immutable, but StoredEvent's occurredOn is mutable because of DateTime type.
https://github.com/dddinphp/ddd/blob/master/src/Domain/Event/StoredEvent.php#L34

Especially last-wishes app fires Event with DateTimeImmutable type - inconsistency that throws Exception.
https://github.com/bystro/last-wishes/blob/master/src/Lw/Domain/Model/User/UserRegistered.php#L19

Boys are you open for a PR? I can make some job.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0