This repository was archived by the owner on Feb 4, 2025. It is now read-only.
add benchmarks for normal Dart classes, serialized to JsonBuffers #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also like to separate the "wire" benchmarks out a bunch, specifically I want to have the following:
This should help demonstrate where each of the benchmarks shine and where they do less well, in more fine grained detail. |
davidmorgan
approved these changes
Dec 10, 2024
jakemac53
added a commit
that referenced
this pull request
Dec 13, 2024
… hash (#154) As mentioned in #153. This gives us a better overall picture of where time is going, in the various modes. Current results: ``` SdkMapsJsonWireBenchmark-create: 904ms SdkMapsBufferWireBenchmark-create: 711ms SdkMapsBuilderWireBenchmark-create: 713ms LazyMapsJsonWireBenchmark-create: 0ms LazyMapsBufferWireBenchmark-create: 0ms LazyWrappersBufferWireBenchmark-create: 420ms BuilderMapsJsonWireBenchmark-create: 374ms BuilderMapsBuilderWireBenchmark-create: 379ms SdkMapsJsonWireBenchmark-serialize: 746ms, 7177227 bytes SdkMapsBufferWireBenchmark-serialize: 633ms, 5122684 bytes SdkMapsBuilderWireBenchmark-serialize: 667ms, 4859868 bytes LazyMapsJsonWireBenchmark-serialize: 1104ms, 7177227 bytes LazyMapsBufferWireBenchmark-serialize: 543ms, 5122684 bytes LazyWrappersBufferWireBenchmark-serialize: 0ms, 2111761 bytes BuilderMapsJsonWireBenchmark-serialize: 1028ms, 7177227 bytes BuilderMapsBuilderWireBenchmark-serialize: 0ms, 2111761 bytes SdkMapsJsonWireBenchmark-deserialize: 1249ms SdkMapsBufferWireBenchmark-deserialize: 0ms SdkMapsBuilderWireBenchmark-deserialize: 0ms LazyMapsJsonWireBenchmark-deserialize: 1298ms LazyMapsBufferWireBenchmark-deserialize: 0ms LazyWrappersBufferWireBenchmark-deserialize: 0ms BuilderMapsJsonWireBenchmark-deserialize: 1257ms BuilderMapsBuilderWireBenchmark-deserialize: 0ms SdkMapsJsonWireBenchmark-process: 151ms, hash 23186292 SdkMapsBufferWireBenchmark-process: 249ms, hash 23186292 SdkMapsBuilderWireBenchmark-process: 541ms, hash 23186292 LazyMapsJsonWireBenchmark-process: 179ms, hash 23186292 LazyMapsBufferWireBenchmark-process: 251ms, hash 23186292 LazyWrappersBufferWireBenchmark-process: 367ms, hash 23186292 BuilderMapsJsonWireBenchmark-process: 207ms, hash 23186292 BuilderMapsBuilderWireBenchmark-process: 364ms, hash 23186292 SdkMapsJsonWireBenchmark-total: 3050ms SdkMapsBufferWireBenchmark-total: 1593ms SdkMapsBuilderWireBenchmark-total: 1921ms LazyMapsJsonWireBenchmark-total: 2581ms LazyMapsBufferWireBenchmark-total: 794ms LazyWrappersBufferWireBenchmark-total: 787ms BuilderMapsJsonWireBenchmark-total: 2866ms BuilderMapsBuilderWireBenchmark-total: 743ms ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of my quest to validate any assumptions we have been making about extension types and how performant they are :D
Here are the new results:
Note how much faster the processing step is.
If we add up the wire benchmark times and the processing benchmark times, regular classes are faster. This is even though the processing benchmark is actually implemented in a favorable way for the extension types (iterates map entries in order). If you look up by keys, it is much, much slower.