Ignored .md files should not be read with jupytext

As I also explained in mwouts/jupytext#1306 (comment), the Plugin.should_include at

mkdocs-jupyter/src/mkdocs_jupyter/plugin.py

Lines 60 to 86 in a3cded5

    
           def should_include(self, file): 
        
               ext = os.path.splitext(str(file.abs_src_path))[-1] 
        
               if ext not in self._supported_extensions: 
        
                   return False 
        
               if ext == ".md": 
        
                   # only include markdown files with jupytext frontmatter 
        
                   # that explicitly specifies a python kernel 
        
                   try: 
        
                       data = jupytext.read(file.abs_src_path) 
        
                       if not ( 
        
                           (meta := data.get("metadata", {})) 
        
                           and (kernelspec := meta.get("kernelspec")) 
        
                           and kernelspec["language"] == "python" 
        
                       ): 
        
                           return False 
        
                   except Exception: 
        
                       return False 
        
               srcpath = pathlib.PurePath(file.abs_src_path) 
        
               include = None 
        
               ignore = None 
        
               for pattern in self.config["ignore"]: 
        
                   if srcpath.match(pattern): 
        
                       ignore = True 
        
               for pattern in self.config["include"]: 
        
                   if srcpath.match(pattern): 
        
                       include = True 
        
               return include and not ignore

will attempt to read any .md with jupytext.read, even if .md files are configured to not be included, or to be ignored.

In https://github.com/jorenham/lmo/, this results in many confusing warning messages to be logged to stderr, specifically, the following is printed 12x when I run uv mkdocs build:

INFO    -  MissingIDFieldWarning: Cell is missing an id field, this will become a hard error in future nbformat versions. You may want to use `normalize()` on your notebooks before validations (available since nbformat 5.1.4). Previous versions of nbformat are fixing this issue transparently, and will stop doing so in the future.
             File "/home/joren/Workspace/lmo/.venv/lib/python3.12/site-packages/nbformat/validator.py", line 351, in _normalize
               warnings.warn(
             File "/home/joren/Workspace/lmo/.venv/lib/python3.12/site-packages/nbformat/__init__.py", line 96, in
               validate(nb)

As you can see from mwouts/jupytext#1306, it took me many hours to figure this out, so I think I at least deserve a cookie now. And it would be even better if this could be fixed :)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	def should_include(self, file):
	ext = os.path.splitext(str(file.abs_src_path))[-1]
	if ext not in self._supported_extensions:
	return False
	if ext == ".md":
	# only include markdown files with jupytext frontmatter
	# that explicitly specifies a python kernel
	try:
	data = jupytext.read(file.abs_src_path)
	if not (
	(meta := data.get("metadata", {}))
	and (kernelspec := meta.get("kernelspec"))
	and kernelspec["language"] == "python"
	):
	return False
	except Exception:
	return False
	srcpath = pathlib.PurePath(file.abs_src_path)
	include = None
	ignore = None
	for pattern in self.config["ignore"]:
	if srcpath.match(pattern):
	ignore = True
	for pattern in self.config["include"]:
	if srcpath.match(pattern):
	include = True
	return include and not ignore

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions