8000 Calendar modal UI fixes by dariiing · Pull Request #1615 · cryptpad/cryptpad · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Calendar modal UI fixes #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2024
Merged

Calendar modal UI fixes #1615

merged 3 commits into from
Sep 9, 2024

Conversation

dariiing
Copy link
Contributor
@dariiing dariiing commented Aug 29, 2024 •
edited
Loading

Hello,
This PR fixes #1612 :

  • fixes icon spacing on dropdown buttons (calendar modal)
  • fixes uneven spacing between buttons (calendar modal)

@dariiing dariiing added UI/UX Interfaces & user experience Ready to Review This PR is ready to be checked by another team member labels Aug 29, 2024
@dariiing dariiing added this to the Autumn release (2024.9.0) milestone Aug 29, 2024
@dariiing dariiing self-assigned this Aug 29, 2024
@dariiing dariiing changed the base branch from main to staging August 29, 2024 09:30
@dariiing dariiing marked this pull request as ready for review August 29, 2024 09:30
yflory
yflory approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor
@yflory yflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue about the margin inside the dropdown button comes from a regression I made here. The icon is supposed to be on the left of the text, so we don't need a margin-left. I fixed the issue and removed the margin-left.

@yflory yflory added Ready to Test This PR is ready to be tested and removed Ready to Review This PR is ready to be checked by another team member labels Sep 2, 2024
@yflory yflory merged commit f25714d into staging Sep 9, 2024
@davidbenque davidbenque removed the Ready to Test This PR is ready to be tested label Dec 6, 2024
@mathilde-cryptpad mathilde-cryptpad deleted the calendar-modal-ui-fixes branch December 18, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yflory yflory yflory approved these changes

Assignees

@dariiing dariiing

Labels
UI/UX Interfaces & user experience
Projects
None yet
Milestone
Autumn release (2024.9.0)
Development

Successfully merging this pull request may close these issues.

Adjust icon spacing and align reminder buttons in calendar dialog
3 participants
@dariiing @yflory @davidbenque
0