10000 attribution/license for diff-dom (LGPL) · Issue #1874 · cryptpad/cryptpad · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

attribution/license for diff-dom (LGPL) #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johanneswilm opened this issue Apr 19, 2025 · 2 comments
Closed

attribution/license for diff-dom (LGPL) #1874

johanneswilm opened this issue Apr 19, 2025 · 2 comments
8000
Labels
Dependencies Any software dependancies problems

Comments

@johanneswilm
Copy link

Hey, some years ago you reported a number of issues on the LGPL licensed diff-dom library that I maintain and which you were using. I was wondering why I didn't hear more from you. I noticed you simply added it to your source code, removing all traces of the LGPL license and information about where the code comes from as far as I can tell. It means you now have your own fork of the library and any bug fixes you do do not go back to the original project.

I am wondering if that was intentional.

@johanneswilm johanneswilm changed the title attribution/license for diff-dom attribution/license for diff-dom (LGPL) Apr 19, 2025
@mathilde-cryptpad mathilde-cryptpad added the Dependencies Any software dependancies problems label Apr 22, 2025
@davidbenque
Copy link
Contributor

Hello, as far as I can tell (this pre-dates my work on the project) the code was copied because the team needed a small change when diff-dom had had a major refactoring compared to the version they were using.

In terms of licensing our project uses the REUSE specification, with a copy of the LGPL alongside all other licenses used its application to diff-dom is properly listed and also documented in our lib/changelog. Please let us know if something is missing in terms of crediting/licensing and we can work to correct it.

@johanneswilm
Copy link
Author

I see. Yes, that is not where I would have looked for a license - I would have expected it to be mentioned in the same file or at least the same folder. I guess this is legal then. Too bad you decided to go with a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Any software dependancies problems
Projects
None yet
Development

No branches or pull requests

3 participants
0