8000 fix: Close modals when navigating by zatteo · Pull Request #877 · cozy/cozy-bar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Close modals when navigating #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

fix: Close modals when navigating #877

merged 2 commits into from
May 7, 2025

Conversation

zatteo
Copy link
Member
@zatteo zatteo commented May 7, 2025

Solves to issues :

  • If I am on settings on "Appearance" page and I click on "Manage profile" from cozy-bar UserMenu, it will navigate to "Profile" page but the UserMenu stayed open
  • On flagship app, we need to close the AppsMenu when opening a app because the home is always alive in a separate webview. So when we were going back to the home, the UserMenu stayed open

Todo :

Solves to issues :
- If I am on settings on "Appearance" page and I click on "Manage profile" from cozy-bar UserMenu, it will navigate to "Profile" page but the UserMenu stayed open
- On flagship app, we need to close the AppsMenu when opening a app because the home is always alive in a separate webview. So when we were going back to the home,  the UserMenu stayed open
BREAKING CHANGE: You need to have cozy-ui >= 122.12.1
@zatteo zatteo merged commit 8cda429 into master May 7, 2025
2 checks passed
@zatteo zatteo deleted the fix/close-modal branch May 7, 2025 13:46
@cozy-bot
Copy link
cozy-bot commented May 7, 2025

🎉 This PR is included in version 22.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0