8000 duplicate schema files installed · Issue #1631 · coturn/coturn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

duplicate schema files installed #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gdt opened this issue Jan 19, 2025 · 0 comments
Open

duplicate schema files installed #1631

gdt opened this issue Jan 19, 2025 · 0 comments

Comments

@gdt
Copy link
gdt commented Jan 19, 2025

Tested today with 4.6.3 release, NetBSD 10 amd64.

I am creating a pkgsrc entry for coturn (in pkgsrc-wip first), for NetBSD and others. Within $PREFIX, I am seeing both a share/coturn and a share/docs/coturn. That's fine. A bunch of things are in one or the other, as appropriate, also fine. But I am seeing the schema files in both, and I think the installation into docs is extra and shouldn't happen. From my destdir after building:

share/coturn/schema.mongo.sh
share/coturn/schema.sql
share/coturn/schema.stats.redis
share/coturn/schema.userdb.redis
share/doc/coturn/schema.mongo.sh
share/doc/coturn/schema.sql
share/doc/coturn/schema.stats.redis
share/doc/coturn/schema.userdb.redis

This looks perhaps intentional, from Makefile;

        ${INSTALL_DATA} turndb/schema.sql ${DESTDIR}${DOCSDIR}
        ${INSTALL_DATA} turndb/schema.sql ${DESTDIR}${SCHEMADIR}
        ${INSTALL_DATA} turndb/schema.mongo.sh ${DESTDIR}${DOCSDIR}
        ${INSTALL_DATA} turndb/schema.mongo.sh ${DESTDIR}${SCHEMADIR}
        ${INSTALL_DATA} turndb/testredisdbsetup.sh ${DESTDIR}${SCHEMADIR}
        ${INSTALL_DATA} turndb/testmongosetup.sh ${DESTDIR}${SCHEMADIR}
        ${INSTALL_DATA} turndb/testsqldbsetup.sql ${DESTDIR}${SCHEMADIR}
        ${INSTALL_DATA} turndb/schema.userdb.redis ${DESTDIR}${DOCSDIR}
        ${INSTALL_DATA} turndb/schema.userdb.redis ${DESTDIR}${SCHEMADIR}
        ${INSTALL_DATA} turndb/schema.stats.redis ${DESTDIR}${DOCSDIR}
        ${INSTALL_DATA} turndb/schema.stats.redis ${DESTDIR}${SCHEMADIR}

but it doesn't make sense to me.

I suggest just installing schemas into ${SCHEMADIR}.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdt
0