This repository was archived by the owner on Feb 24, 2020. It is now read-only.
doc/using-rkt-with-systemd: fix the go app example #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
suggested changes
Sep 19, 2016
| @@ -131,12 +131,17 @@ func main() { | |||
| }) | |||
| ln, err := net.Listen("tcp", ":5000") | |||
| if err != nil { | |||
| fmt.Fprintf(os.Stderr, "%v\n", err) | |||
| log.Errorf("Listen failed: %s", err) | |||
There was a problem hiding this comment.
There is no Errorf in module log.
There was a problem hiding this comment.
I got confused with another module. will put back fmt.Fprintf
There was a problem hiding this comment.
Even better I will use log.Fatalf(...)
There was a problem hiding this comment.
Ack. Fatalf already calls Exit(1) internally, so you may also remove that.
| os.Exit(1) | ||
| } | ||
| err = daemon.SdNotify("READY=1") | ||
| sent, err = daemon.SdNotify("READY=1") |
| if err != nil { | ||
| log.Printf("daemon.SdNotify READY=1 return: %s", err) | ||
| log.Errorf("Notification failed: %s", err) | ||
| 8000 | os.Exit(1) |
There was a problem hiding this comment.
You also need to import module os.
b1b9d07 to
063ec3c
Compare
|
@lucab updated |
`daemon.SdNotify` returns 2 variables.
063ec3c to
5491fef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
daemon.SdNotifyreturns 2 variables.