This repository was archived by the owner on Feb 24, 2020. It is now read-only.
vendor: use appc/spec 0.8.6 and k8s.io/kubernetes v1.3.0 #3063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, tests are failing to build due to API changes. |
8000
Ah, I was hoping to only cherry-pick some changes from #2880 to avoid the glide conflicts while the recursive mounts is being fixed. I guess it's not that easy then. |
29058fb to
ef896a1
Compare
|
I added a patch to fix the tests caused by the vendoring updates. The tests seem to pass now. I didn't have time to address @krnowak's concern. |
Based on Stefan Junker's work from rkt#2880
ef896a1 to
9abbcba
Compare
Done by the script scripts/bump-appc-spec-version as explained in rkt#3063 (comment)
|
LGTM too. |
15 tasks
antoni
pushed a commit
to intelsdi-x/rkt
that referenced
this pull request
Sep 9, 2016
Done by the script scripts/bump-appc-spec-version as explained in rkt#3063 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And tests/ctx: tolerate incomplete child processes
Based on @steveej's work on #2880. I am taking the couple of patches that are ready, so we can get the vendoring changes merged without having to resolve conflicts on glide.lock while the work in #2880 is getting ready.
/cc @steveej @iaguis