This repository was archived by the owner on Feb 24, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35d5ced to
ec1d90a
Compare
This avoid hardcoding paths like /usr/lib64 which may not be valid on some distros.
We were using the variable name instead of the actual variable.
I could not find where systemd tries to load libnss_files, so probably it does not do it directly. But apparently the loader does not like the hardcoded /usr/lib path in the ACI rootfs, so instead put the libnss_files libraries in the same directory as found on host.
ec1d90a to
39ffc2a
Compare
|
I tested it on my computer (fedora 24) and all the tests that failed here (https://jenkins-rkt-public.prod.coreos.systems/job/rkt-master-periodic/os_type=fedora-24,stage1_flavor=src_master/105/consoleFull) passed. Didn't check other tests. |
|
Basically, I called |
|
I tested it on debian and fedora24 with the flavor src-v231 and it worked too. |
|
lgtm |
|
Travis is broken ATM: https://blog.travis-ci.com/2016-08-09-outage-gce-images Merging anyway since the other tests passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not find where systemd tries to load libnss_files, so probably
it does not do it directly. But apparently the loader does not like
the hardcoded /usr/lib path in the ACI rootfs, so instead put the
libnss_files libraries in the same directory as found on host.