This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage1: disabling cgroup namespace in systemd-nspawn #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af161b6 to
1520ad8
Compare
| // This was introduced by https://github.com/systemd/systemd/pull/3809 and it will cause | ||
| // problems in rkt when cgns is enabled and cgroup-v1 is used. For more information see | ||
| // https://github.com/systemd/systemd/pull/3589#discussion_r70277625. | ||
| // This patch tells systemd-nspawn not to use cgroup namespace using the environment variable |
There was a problem hiding this comment.
s/This patch/The following line/?
|
One nit, LGTM if green otherwise. @iaguis it fixed the issue in your test, right? |
If the kernel has the cgroup namespace enabled, systemd v232 will use it by default. This was introduced by systemd/systemd#3809 and it will cause problems in rkt when cgns is enabled and cgroup-v1 is used. For more information see systemd/systemd#3589 (comment). This patch tells systemd-nspawn not to use cgroup namespace using the environment variable introduced by systemd/systemd#3809.
1520ad8 to
8fcb19a
Compare
|
There's a weird timeout on Fedora 24, it seems the tests hanged on It doesn't seem related to this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the kernel has the cgroup namespace enabled, systemd v232 will use it
by default. This was introduced by systemd/systemd#3809
and it will cause problems in rkt when cgns is enabled and cgroup-v1 is used.
For more information see systemd/systemd#3589 (comment).
This patch tells systemd-nspawn not to use cgroup namespace using
the environment variable introduced by systemd/systemd#3809.