This repository was archived by the owner on Feb 24, 2020. It is now read-only.
rkt-monitor: misc fixes #2927
Merged
rkt-monitor: misc fixes #2927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Fix to build issue introduced with glide? (BINDIR -> TARGET_BINDIR)
- Fix to build issue with rkt v1.10
- New flag: output-dir, output CSV files will be placed there
- New flag: rkt-dir: directory with rkt binary
- New flag: stage1-path: which flavor use in tests
- CSV output filename now contains date, time and flavor
- Output file flag don't prevents printing result summary to stdout
|
Can one of the admins verify this patch? |
| func saveRecords(records [][]string, prefix string) error { | ||
| csvFile, err := ioutil.TempFile("", prefix) | ||
| func saveRecords(records [][]string, dir, filename string) error { | ||
| if dir == "" { |
|
small nit, else LGTM |
|
ok to test |
4e48b7e to
11a9bf6
Compare
06df192 to
ed93f5c
Compare
|
LGTM |
|
LGTM, but I'd ask you to split into two separate commits with appropriate commit messages adhering to https://github.com/coreos/rkt/blob/master/CONTRIBUTING.md#format-of-the-commit-message:
|
* Fix to build issue introduced with glide? (BINDIR -> TARGET_BIN * Fix to build issue with rkt v1.10
* New flag: output-dir, output CSV files will be placed there * New flag: rkt-dir: directory with rkt binary * New flag: stage1-path: which flavor use in tests * CSV output filename now contains date, time and flavor * Flag "--to-file" won't suppress printing summary on stdout
ed93f5c to
23ce50e
Compare
|
PTAL @s-urbaniak |
|
Thanks! LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.