8000 Bug in __init__.py · Issue #22 · consbio/tpkutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bug in __init__.py #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hrishereforyou opened this issue May 1, 2018 · 4 comments
Open

Bug in __init__.py #22

hrishereforyou opened this issue May 1, 2018 · 4 comments

Comments

@hrishereforyou
Copy link

bug init.py line 201
r_off, c_off = [int(x, 16) for x in root.lstrip('R').split('C')]

Range of hex is 0-F so could contain C.
possible fix
r_off, c_off = [int(x, 16) for x in [root[1:5], root[6:10]]]
@jeff3780
Copy link

I received this same error, but I believe for a different reason. Inside my tpk was a bundle with a .bundle.done filetype per the logging message:

INFO:tpkutils:Reading bundle: v101/Layers/_alllayers/L00/R0000C0000.bundle
INFO:tpkutils:Reading bundle: v101/Layers/_alllayers/L00/R0000C0000.bundle.done

then in the Traceback while trying to process the bundle.done bundle:
....
File "C:\Software\Anaconda3\envs\JLPy35\lib\site-packages\tpkutils_init_.py", line 201, in
r_off, c_off = [int(x, 16) for x in root.lstrip('R').split('C')]
ValueError: invalid literal for int() with base 16: '0000.bundle'

I wonder why the tile package contained a 'bundle.done' file, and if so, would it be OK to ignore it? (Since there was a bundle file with the same root, but no .done suffix)

I used Esri GP tool 'Create Map Tile Package' from ArcToolbox to create the tpk.

@brendan-ward
Copy link
Collaborator

@jeff3780 would you mind trying to create your TPK file again, and inspect it to see if the new one also contains the *.bundle.done file? It might be that the bundle was not fully created due to some error, and this may be masking a potential issue.

Also - what version of ArcGIS did you use?

@jeff3780
Copy link

@brendan-ward I am using the latest 10.7 version of ArcGIS. I went ahead and reran the tpk as you suggested, and this time, no *.bundle.done were generated into the tpk. I used the same mxd, extent, and tiling scheme as I had before when it did generate those .done bundles.

When I previously generated the tpk (with the .done bundles), I was watching the folder structure being created using Windows Explorer, so that I could see what was going on behind the scenes. I wonder if that corrupted the process somehow? This time, I just set the GP tool running, and left everything alone until it was completed.

If my actions did cause the corruption, then I guess a word to the wise to not mess with things as the GP tool is running. On the other hand, it might be worth a quick scan of bundle names just to make sure, and to avoid the exception. I could probably put that in a try/catch, and warn the user to regen if caught.

With all that being said, nice job on this code! I think it is going to be very useful for an upcoming project that I am working on. Thanks for your efforts, and for the reference to other resources describing the formats involved.

@brendan-ward
Copy link
Collaborator

@jeff3780 I'm glad this is useful for you, and also glad that it is holding up in ArcGIS 10.7 (several versions newer than I've tested).

A PR to address this issue, as you've described, would be very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brendan-ward @jeff3780 @hrishereforyou
0