8000 Document `--platform` flag for `conda [env] create` by jaimergp · Pull Request #14181 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Document --platform flag for conda [env] create #14181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

jaimergp
Copy link
Contributor
@jaimergp jaimergp commented Aug 27, 2024

Description

Closes #14100

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 27, 2024
@jaimergp jaimergp marked this pull request as ready for review August 27, 2024 09:40
@jaimergp jaimergp requested a review from a team as a code owner August 27, 2024 09:40
jezdez
jezdez previously approved these changes Aug 27, 2024
@jezdez jezdez requested a review from kathatherine August 27, 2024 11:52
However, in some cases you might want to create an environment for a
different target platform or architecture. To do so, use the
``--platform`` flag available in the ``conda create`` and
``conda env create`` commands. The value must be a valid platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a list of valid platforms in the documentation? Would be a nice thing to link to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link added.

@travishathaway
Copy link
Contributor

Thanks for picking up my open issue! 🚀 Couple suggestions for improvement, but it looks good.

Copy link
Contributor
@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on all of Travis' comments, plus a few of my own!

- The environment can be solved, but extraction and linking fails due
filesystem limitations (case insensitive systems, incompatible paths,
etc). The only workaround here is to use ``--dry-run --json`` to obtain
the solution and process the payload into a lockfile that can be shared
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have docs on lockfiles and how to use them? Might be a useful link here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a new section because I couldn't find one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!

However, in some cases you might want to create an environment for a
different target platform or architecture. To do so, use the
``--platform`` flag available in the ``conda create`` and
``conda env create`` commands. The value must be a valid platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>
Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
@jaimergp
Copy link
Contributor Author

pre-commit.ci autofix

Copy link
Contributor
@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments on my end for your new section, Jaime

They consist of a ``@EXPLICIT`` header plus a list of conda package URLs optionally followed
by their MD5 or SHA256 hash.

They can be obtained from existing environments via ``conda list --explicit``, as seen in ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to put something here!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaimergp This seems empty still?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, addressed!

- The environment can be solved, but extraction and linking fails due
filesystem limitations (case insensitive systems, incompatible paths,
etc). The only workaround here is to use ``--dry-run --json`` to obtain
the solution and process the payload into a lockfile that can be shared
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!

Co-authored-by: Katherine Kinnaman <kkinnaman@anaconda.com>
Copy link
Member
@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jezdez
jezdez previously approved these changes Sep 3, 2024
@jezdez
Copy link
Member
jezdez commented Sep 3, 2024

pre-commit.ci autofix

@jaimergp jaimergp merged commit 9d5744b into conda:main Sep 5, 2024
13 checks passed
@beeankha beeankha mentioned this pull request Sep 27, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Option --platform/--subdir is not mentioned in documentation
5 participants
0