10000 TestWriteRPCResponseHTTPError is flaky · Issue #1913 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TestWriteRPCResponseHTTPError is flaky #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1923
faddat opened this issue Jan 1, 2024 · 0 comments · Fixed by #1945
Closed
Tracked by #1923

TestWriteRPCResponseHTTPError is flaky #1913

faddat opened this issue Jan 1, 2024 · 0 comments · Fixed by #1945
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Milestone
2024-Q1

Comments

@faddat
Copy link
Contributor
faddat commented Jan 1, 2024 •
edited
Loading

Bug Report

TestWriteRPCResponseHTTPError is flaky

Setup

I did it all in CI.

What happened?

Adding a godoc to trigger CI with no code changes resolved the test failure

What did you expect to happen?

The tests should either pass or not, consistently

How to reproduce it

Work on comet and I suppose that eventually TestWriteRPCResponseHTTPError will fail on you.

Logs

Anything else we need to know

I "fixed" this by adding a godoc to a test function. That fix shouldn't work.
@faddat faddat added bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team. labels Jan 1, 2024
This was referenced Jan 1, 2024
Merged
Open
Merged
@adizere adizere added this to CometBFT Jan 15, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Jan 15, 2024
@adizere adizere added this to the 2024-Q1 milestone Jan 15, 2024
@adizere adizere moved this from Todo to Done in CometBFT Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q1
Development

Successfully merging a pull request may close this issue.

Fix HTTP response body not being closed after reading faddat/cometbft
2 participants
@adizere @faddat
0