8000 TestListenerTimeoutReadWrite is flaky · Issue #1915 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TestListenerTimeoutReadWrite is flaky #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1923
faddat opened this issue Jan 1, 2024 · 2 comments · Fixed by #1947
Closed
Tracked by #1923

TestListenerTimeoutReadWrite is flaky #1915

faddat opened this issue Jan 1, 2024 · 2 comments · Fixed by #1947
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Milestone
2024-Q1

Comments

@faddat
Copy link
Contributor
faddat commented Jan 1, 2024 •
edited
Loading

Bug Report

TestListenerTimeoutReadWrite is flaky

Setup

I just used CI

Config

CI

What happened?

With no code changes other than a godoc, TestListenerTimeoutReadWrite decided to fail

What did you expect to happen?

I expected no tests to fail other than those that failed in the previous commit

How to reproduce it

Just work on comet

logs

Screenshot 2024-01-02 at 3 12 09 AM

Another one:

But then I added a godoc, and another test failed!

TestListenerTimeoutReadWrite

There were no code changes other than the godoc. Godoc should not affect test success or failure. The situation with flaky tests is robbing us of a source of truth for comet.

Anything else we need to know

Making CI reliable provides a source of truth as to the state of the code and eliminates "works on my machine" problems. If we wish to improve the reliability of comet, we need to determine why these tests are flaky, and fix it.
@faddat faddat added bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team. labels Jan 1, 2024
@faddat
Copy link
Contributor Author
faddat commented Jan 1, 2024

note to self: TestByzantinePrevoteEquivocation could be too

This was referenced Jan 1, 2024
Closed
Merged
Open
Merged
@faddat
Copy link
Contributor Author
faddat commented Jan 6, 2024

fixed in #1954

@faddat faddat closed this as completed Jan 6, 2024
@adizere adizere added this to the 2024-Q1 milestone Jan 10, 2024
@adizere adizere added this to CometBFT Jan 15, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Jan 15, 2024
@adizere adizere moved this from Todo to Done in CometBFT Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team.
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q1
Development

Successfully merging a pull request may close this issue.

fix TestListenerTimeoutReadWrite faddat/cometbft
2 participants
@adizere @faddat
0