jsonrpc should respect HTTP(S) default port number #1902
Labels
Milestone
Comments
gibson042
added a commit
to gibson042/cometbft
that referenced
this issue
Dec 28, 2023
3 tasks
gibson042
added a commit
to gibson042/cometbft
that referenced
this issue
Dec 28, 2023
This was referenced Dec 28, 2023
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 16, 2024
…t port (#1903) Closes #1902 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments
mergify bot
pushed a commit
that referenced
this issue
Jan 16, 2024
…t port (#1903) Closes #1902 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit 9c9ffba)
mergify bot
pushed a commit
that referenced
this issue
Jan 16, 2024
…t port (#1903) Closes #1902 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit 9c9ffba) # Conflicts: # rpc/jsonrpc/client/http_json_client_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Feature Request
Summary
RPC clients should infer an unspecified port number from the HTTP(S) default when applicable.
Problem Definition
Currently, the destination of every network-based RPC server must be specified with a URL including an explicit host port number (e.g., Cosmos SDK
--node tcp://localhost:26657). But the scheme part of such URLs can be e.g. "http" or "https", which imply a default port number (respectively, 80 or 443).MakeHTTPDialershould respect those defaults, rather than causing behavior like this:Proposal
Update jsonrpc to use port 80 when scheme is "http" and no port number is specified and port 443 when scheme is "https" and no port number is specified, in accordance with RFC 9110.
Suggestion:
// GetDialAddress returns the endpoint to dial for the parsed URL. func (u parsedURL) GetDialAddress() string { - // if it's not a unix socket we return the host, example: localhost:443 + // if it's not a unix socket we return the host with port, example: localhost:443 if !u.isUnixSocket { + hasPort, err := regexp.MatchString(`:[0-9]+$`, u.Host) + if err == nil && !hasPort { + if u.Scheme == protoHTTP || u.Scheme == protoWS { + return u.Host + `:80` + } else if u.Scheme == protoHTTPS || u.scheme == protoWSS { + return u.Host + `:443` + } + } return u.Host } // otherwise we return the path of the unix socket, ex /tmp/socket return u.GetHostWithPath() }The text was updated successfully, but these errors were encountered: