8000 e2e: The new e2e tests found 2 scenarios where CometBFT is not respecting ABCI 1.0 grammar. · Issue #1581 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

e2e: The new e2e tests found 2 scenarios where CometBFT is not respecting ABCI 1.0 grammar. #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nenadmilosevic95 opened this issue Nov 7, 2023 · 0 comments · Fixed by #1829 or #2190
Closed

e2e: The new e2e tests found 2 scenarios where CometBFT is not respecting ABCI 1.0 grammar. #1581

nenadmilosevic95 opened this issue Nov 7, 2023 · 0 comments · Fixed by #1829 or #2190
Assignees
@nenadmilosevic95
Labels
bug Something isn't working e2e Related to our end-to-end tests

Comments

@nenadmilosevic95
Copy link
Contributor

Problem explanation

The new e2e tests (#902, #930) that verify whether CometBFT respects the ABCI grammar disclosed two scenarios in which this is not the case. Specifically, the scenarios were observed while running ci.toml testnet and they are the following:

  1. One of the validator nodes is calling init_chain even though it runs in a recovery mode and not in a clean-start mode.
  2. One of the full nodes is not calling init_chain in the beginning.

The same can be reproduced by running e2e tests with ci.toml testnet. Please remember to enable ABCI tests by setting
abci_tests_enabled = true in ci.toml file.
@nenadmilosevic95 nenadmilosevic95 added bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team. labels Nov 7, 2023
@andynog andynog added e2e Related to our end-to-end tests and removed needs-triage This issue/PR has not yet been triaged by the team. labels Nov 9, 2023
@nenadmilosevic95 nenadmilosevic95 mentioned this issue Dec 14, 2023
Merged
3 tasks
@sergio-mena sergio-mena moved this from Todo to In Progress in CometBFT 2023 Dec 15, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in CometBFT 2023 Dec 22, 2023
@adizere adizere mentioned this issue Jan 12, 2024
Open
@melekes melekes mentioned this issue Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nenadmilosevic95 nenadmilosevic95

Labels
bug Something isn't working e2e Related to our end-to-end tests
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
3 participants
@cason @andynog @nenadmilosevic95
0