8000 Add additional invariant check to `enterCommit` · Issue #1207 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add additional invariant check to enterCommit #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sergio-mena opened this issue Aug 4, 2023 · 0 comments · Fixed by #1208
Closed

Add additional invariant check to enterCommit #1207

sergio-mena opened this issue Aug 4, 2023 · 0 comments · Fixed by #1208
Assignees
@sergio-mena
Labels
consensus
Milestone
2023-Q3

Comments

@sergio-mena
Copy link
Contributor
sergio-mena commented Aug 4, 2023 •
edited
Loading

Was: tendermint/tendermint#7020

Part of: #1171

During tendermint/tendermint#6954 it was discovered that enterCommit does not check that the block that has received +2/3 precommits is non-nil. This check is performed outside of the call to enterCommit but should likely also be added to enterCommit to safeguard against the check not being included outside the method for future uses.

This issue was cloned from Tendermint Core repo as a follow up of #1175 (tracked by #1171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergio-mena sergio-mena

Labels
consensus
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
2023-Q3
Development

Successfully merging a pull request may close this issue.

Add check for non-nil in enterCommit cometbft/cometbft
1 participant
@sergio-mena
0