10000 logs: adopt the `Warn` level when best suited · Issue #4453 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

logs: adopt the Warn level when best suited #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cason opened this issue Nov 7, 2024 · 2 comments
Open

logs: adopt the Warn level when best suited #4453

cason opened this issue Nov 7, 2024 · 2 comments
Labels
logs Anything relating to logging P:operator-experience Priority: Improve experience for operators

Comments

@cason
Copy link
Contributor
cason commented Nov 7, 2024

With the introduction of slog (#4374), we have an additional Warn log level available for all CometBFT components.

We have in the code base several situations where this new level would be best suited, for instance:

./config/config.go: // CheckDeprecated returns any deprecation warnings. These are printed to the operator on startup.
./node/node.go:		logger.Info("warning: cannot verify appHash. Verification will happen when node boots up!")
./p2p/pex/known_address.go:			// log.Warn(Fmt("Bucket already exists in ka.Buckets: %v", ka))
./internal/consensus/wal.go:		wal.Logger.Error("Error writing msg to consensus wal. WARNING: recover may not be possible for the current height",

We should adapt the logging level in order to render some messages more visible, with the introduction of this new log level.
@cason cason added P:operator-experience Priority: Improve experience for operators logs Anything relating to logging labels Nov 7, 2024
@faddat
Copy link
Contributor
faddat commented Nov 27, 2024

With this issue, you are basically trying to make the info view less chatty?

@cason
Copy link
Contributor Author
cason commented Nov 29, 2024

Yes. If you choose warn as default level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
logs Anything relating to logging P:operator-experience Priority: Improve experience for operators
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cason @faddat
0