Open
Description
Currently we diverge from the original behavior when openpilot (alpha) longitudinal is used, which has confused some users in the past having them ask on Discord how to engage.
We should match the stock longitudinal button logic in panda and openpilot, here's what we don't match:
- CAN cars with set, resume, and main on button
- Match main on button, which is a grate on whether cruise is "available". For example, pressing it has no effect on availability, nor resetting cruise speed, etc.
- Resume should not be allowed if no cruise speed set (immediately after toggling main/availability)
- CAN and CAN FD cars with set, pause/resume, and main on button that toggles cruise:
- Above criteria for main button, in addition to enabling cruise on rising edge the first time.
- Pause/resume button should toggle cruise on and off if cruise is available.
- Not all HKG cars have this main and pause/resume button functionality and this button shows up as the normal resume button to openpilot, so we ideally need a way to differentiate these buttons/cars.
This needs to be done for both Hyundai's CAN and CAN FD platforms.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Open