8000 Add style guide · Issue #815 · collective/icalendar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add style guide #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
niccokunzmann opened this issue Apr 29, 2025 · 5 comments
Open
5 tasks

Add style guide #815

niccokunzmann opened this issue Apr 29, 2025 · 5 comments
Labels

Comments

@niccokunzmann
Copy link
Member
niccokunzmann commented Apr 29, 2025

We are in the process of making the documentation nicer.

In order for it to be consistent, we should add a style guide in the maintenance section of the documentation.

  • (1) decide on style guide for docs
    • must specify headings
  • document style guide in the maintenance section
  • format the documentation according to the style guide
  • make sure all cross-references are found and renamed.

See also:

@stevepiercy, could you solve (1)?

@stevepiercy
Copy link
Member

In Plone projects, we use Vale for checking American English spelling, grammar, and syntax, as well as checking for compliance with a style guide. We selected the Microsoft Writing Style Guide, but there are others available.

We can specify our own dictionary terms as well. For example, we'd want to add icalendar to the accept.txt dictionary, which would also reject an incorrect casing of iCalendar. This has been awesome for adhering to a brand name, such as Node.js, which often gets incorrectly spelled as node, nodejs, Node.JS, and other mutations.

@niccokunzmann
Copy link
Member Author
niccokunzmann commented Apr 29, 2025

I found fluffy using vale. It looks really professional. That also touches on the way we handle dependencies in icalendar as Vale is installed with pip. Also, I wonder how to use Vale with Python code documentation. How does it integrate with sphinx and restructured text?

@stevepiercy
Copy link
Member

This is how Vale handles reStructuredText.

Vale runs independently of Sphinx, but instead uses the underlying docutils library. Sphinx also uses docutils.

In earlier iterations of Plone documentation, we used pip to install dependencies. Then we switched to uv pip install, but that still suffered from pip's inherent inability to perfectly resolve dependencies. We recently switched to plain old uv to avoid that problem, as well as dealing with installing a Python, a virtual environment, and managing dependencies. It's so much easier to write Getting Started documentation by removing such pre-requisites.

We use GNU Make commands to run builds, tests, and everything else. We don't have to remember fancy command flags or options, just make install or make html, and the same command works across many Plone projects. In one Plone project, we use Make to call tox to call a docs build, too.

@niccokunzmann
Copy link
Member Author

vale also handles HTML. We can use vale to run over the HTML documentation and test that. The Python documentation does not seem to be included otherwise but contains a lot of text.

@stevepiercy
Copy link
Member

I haven't tried HTML because it requires a successful HTML build, which doesn't always happen.

@stevepiercy stevepiercy added the doc label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants
0