8000 db: space amp due to virtual tables not accounted in Pebble metrics · Issue #4574 · cockroachdb/pebble · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

db: space amp due to virtual tables not accounted in Pebble metrics #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sumeerbhola opened this issue Apr 17, 2025 · 0 comments
Open

Comments

@sumeerbhola
Copy link
Collaborator
sumeerbhola commented Apr 17, 2025

We compute an estimated size for each virtual sst based on the blocks it references in the backing sst. And we correctly use the backing sst size when computing the aggregate size of the DB (for all the metrics that are used in the calculation of Metrics.DiskSpaceUsage()).
But we don't account for the space amp e.g. if backing sst0 has size 100 and is referenced by sst1 and sst2 that have size 10 and 20 respectively, then 100-(10+20)=70 is garbage. When we see higher than expected size of a DB, being able to put an exact number to such space amp is useful. Came up in the context of https://github.com/cockroachlabs/support/issues/3264

Jira issue: PEBBLE-410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant
0