8000 Performance regression in version 1.2 · Issue #374 · coccinelle/coccinelle · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Performance regression in version 1.2 #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ribalda opened this issue Aug 5, 2024 · 2 comments
Open

Performance regression in version 1.2 #374

ribalda opened this issue Aug 5, 2024 · 2 comments

Comments

@ribalda
Copy link
ribalda commented Aug 5, 2024

Hi there,

Debian recently updated their version from 1.1.1 to 1.2. As a result of that, our CI is running 7.5 times slower.

root@a361d9092793:/workdir# time make coccicheck M=drivers/media/
MODE=report V=1  > 1.1.1.txt

real    1m59.021s
user    53m53.038s
sys     2m17.171s
root@a361d9092793:/workdir# apt-get update
Get:1 http://deb.debian.org/debian trixie InRelease [169 kB]
Get:2 http://deb.debian.org/debian trixie-updates InRelease [49.6 kB]
Get:3 http://deb.debian.org/debian-security trixie-security InRelease [43.5 kB]
Get:4 http://deb.debian.org/debian trixie/main amd64
Packages.diff/Index [27.9 kB]
Ign:4 http://deb.debian.org/debian trixie/main amd64 Packages.diff/Index
Get:5 http://deb.debian.org/debian trixie/main amd64 Packages [9211 kB]
Fetched 9501 kB in 1s (9852 kB/s)
Reading package lists... Done
root@a361d9092793:/workdir# apt-get install coccinelle
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following packages will be upgraded:
  coccinelle
1 upgraded, 0 newly installed, 0 to remove and 71 not upgraded.
Need to get 6644 kB of archives.
After this operation, 3680 kB of additional disk space will be used.
Get:1 http://deb.debian.org/debian trixie/main amd64 coccinelle amd64
1.2.deb-1 [6644 kB]
Fetched 6644 kB in 0s (132 MB/s)
debconf: delaying package configuration, since apt-utils is not installed
(Reading database ... 21008 files and directories currently installed.)
Preparing to unpack .../coccinelle_1.2.deb-1_amd64.deb ...
Unpacking coccinelle (1.2.deb-1) over (1.1.1.deb-6+b1) ...
Setting up coccinelle (1.2.deb-1) ...
root@a361d9092793:/workdir# spatch --version
spatch version 1.2 compiled with OCaml version 4.14.1
Flags passed to the configure script: --prefix=/usr --sysconfdir=/etc
--libdir=/usr/lib --enable-ocaml --enable-python --with-python=python3
--enable-opt
OCaml scripting support: yes
Python scripting support: yes
Syntax of regular expressions: Str
root@a361d9092793:/workdir# time make coccicheck M=drivers/media/
MODE=report V=1  > 1.2.txt

real    15m0.552s
user    371m28.976s
sys     3m32.884s
root@a361d9092793:/workdir#
@evdenis
Copy link
evdenis commented Aug 25, 2024

I also faced than 1.2 works significantly slower then 1.1.1 in my CI. Here one can find that 1.2 hits the timeout https://github.com/evdenis/cvehound/actions/runs/9440777580 whereas previous versions don't.

@vgambier
Copy link
Contributor

Some preliminary git bisect results:

The first bad commit could be any of:
312219d
4388e1d
1cbba8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evdenis @ribalda @vgambier
0