From 9f0a19911a892fb057d87b14569ecb35f7207a2d Mon Sep 17 00:00:00 2001 From: vilmibm Date: Mon, 11 May 2020 12:04:05 -0500 Subject: [PATCH 1/3] de-register review until it's ready to ship --- command/pr_review.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/command/pr_review.go b/command/pr_review.go index bd045378476..5013d2bc226 100644 --- a/command/pr_review.go +++ b/command/pr_review.go @@ -11,7 +11,8 @@ import ( ) func init() { - prCmd.AddCommand(prReviewCmd) + // TODO re-register post release + // prCmd.AddCommand(prReviewCmd) prReviewCmd.Flags().BoolP("approve", "a", false, "Approve pull request") prReviewCmd.Flags().BoolP("request-changes", "r", false, "Request changes on a pull request") From 1675a677d6a9c54f9d97941e90ae0bb2fad96200 Mon Sep 17 00:00:00 2001 From: vilmibm Date: Mon, 11 May 2020 12:04:24 -0500 Subject: [PATCH 2/3] hide credits from main help --- command/root.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/command/root.go b/command/root.go index ebd5445d26a..3ef268cb79a 100644 --- a/command/root.go +++ b/command/root.go @@ -271,7 +271,7 @@ func rootHelpFunc(command *cobra.Command, s []string) { s := " " + rpad(c.Name()+":", c.NamePadding()) + c.Short if includes(coreCommandNames, c.Name()) { coreCommands = append(coreCommands, s) - } else { + } else if c != creditsCmd { additionalCommands = append(additionalCommands, s) } } From 569595894f543db8817f8b700ca23d4e51e38109 Mon Sep 17 00:00:00 2001 From: vilmibm Date: Mon, 11 May 2020 12:09:21 -0500 Subject: [PATCH 3/3] skip review tests for now --- command/pr_review_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/command/pr_review_test.go b/command/pr_review_test.go index 96ceabd7e32..781b2cb0656 100644 --- a/command/pr_review_test.go +++ b/command/pr_review_test.go @@ -8,6 +8,7 @@ import ( ) func TestPRReview_validation(t *testing.T) { + t.Skip("skipping until release is done") initBlankContext("", "OWNER/REPO", "master") http := initFakeHTTP() for _, cmd := range []string{ @@ -22,6 +23,7 @@ func TestPRReview_validation(t *testing.T) { } func TestPRReview_url_arg(t *testing.T) { + t.Skip("skipping until release is done") initBlankContext("", "OWNER/REPO", "master") http := initFakeHTTP() http.StubRepoResponse("OWNER", "REPO") @@ -67,6 +69,7 @@ func TestPRReview_url_arg(t *testing.T) { } func TestPRReview_number_arg(t *testing.T) { + t.Skip("skipping until release is done") initBlankContext("", "OWNER/REPO", "master") http := initFakeHTTP() http.StubRepoResponse("OWNER", "REPO") @@ -112,6 +115,7 @@ func TestPRReview_number_arg(t *testing.T) { } func TestPRReview_no_arg(t *testing.T) { + t.Skip("skipping until release is done") initBlankContext("", "OWNER/REPO", "feature") http := initFakeHTTP() http.StubRepoResponse("OWNER", "REPO") @@ -147,6 +151,7 @@ func TestPRReview_no_arg(t *testing.T) { } func TestPRReview_blank_comment(t *testing.T) { + t.Skip("skipping until release is done") initBlankContext("", "OWNER/REPO", "master") http := initFakeHTTP() http.StubRepoResponse("OWNER", "REPO") @@ -156,6 +161,7 @@ func TestPRReview_blank_comment(t *testing.T) { } func TestPRReview_blank_request_changes(t *testing.T) { + t.Skip("skipping until release is done") initBlankContext("", "OWNER/REPO", "master") http := initFakeHTTP() http.StubRepoResponse("OWNER", "REPO") @@ -165,6 +171,7 @@ func TestPRReview_blank_request_changes(t *testing.T) { } func TestPRReview(t *testing.T) { + t.Skip("skipping until release is done") type c struct { Cmd string ExpectedEvent string