8000 Upwards arrow on empty buffer should bring last message into edit mode · Issue #97 · cinnyapp/cinny · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upwards arrow on empty buffer should bring last message into edit mode #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tmpod opened this issue Sep 13, 2021 · 14 comments · Fixed by #774
Closed

Upwards arrow on empty buffer should bring last message into edit mode #97

Tmpod opened this issue Sep 13, 2021 · 14 comments · Fixed by #774

Comments

@Tmpod
Copy link
Tmpod commented Sep 13, 2021

Is your feature request related to a problem? Please describe.

Editing the last message sent to quickly fix a mistake is a bit of a hassle at the moment. I have to grab my mouse and click the edit button.

Describe the solution you'd like

Like in many other clients and platforms (like Discord, which you're trying to replicate) allow you to enter edit mode on that last message by clicking on the upwards arrow when the message buffer is empty. This should be implemented in Cinny.

Describe alternatives you've considered

Some other key could be used, but I haven't thought of anything else outside of that.

@ajbura ajbura added the type: feature New feature or request label Sep 14, 2021
@blattersturm
Copy link

In addition to this, I noticed these two flow things:

  1. Manually clicking the edit button doesn't seem to focus the edit field, requiring a second click. This is probably best off as a second issue, however.
  2. In Element, pressing up/down when at the start or end of an edit text box seems to move up to editing the message above/below it. This feature could be useful?

@Tmpod
Copy link
Author
Tmpod commented Sep 20, 2021 via email

@Tmpod
Copy link
Author
Tmpod commented Oct 2, 2021 via email

@BachoSeven
Copy link

This would go a long way of making Cinny more accessible to heavy keyboard users.

Just wanted to add that when this gets implemented it would be nice to also have Ctrl+Up/DownArrow to reply to messages, as it works in element.

@deanveloper
Copy link
Contributor
deanveloper commented May 12, 2022

the way that slack and discord both work (which i really like)

empty text box: up-arrow edits previous message
anything in text box: up-arrow moves caret, even if it's at the beginning of the text box it will not ever edit

another feature i really like that ties into this - pressing tab highlights the "send message" box, and using the up/down arrows navigate through messages. pressing E will edit the currently highlighted message, allowing you to edit messages besides the last one you sent

@exodrifter
Copy link
Contributor

I talked about this with a friend and we would like to throw our hat in the ring. We think it would be better if pressing up highlighted the last message that was sent in the room and allowed you to pick between any of the message options you normally get on mouse hover.

This way, you could press up arrow until you get to the message you want, use the left and right arrow buttons to navigate between message actions, and use the enter key to do do that action. If we designed it this way, it would be nice to automatically select the edit button and place it in the middle so you would only need one keypress to pick either one of the other two options.

This solves a few problems:

  • Pressing up while you're editing a message to get to your next-to-last message seems undesirable since you could potentially lose edits.
  • You don't need to add more key combinations do other actions (such as the aforementioned pressing tab then up and down to select messages).

@blattersturm
Copy link

use the left and right arrow buttons to navigate between message actions, and use the enter key to do do that action

In this case, would it make sense to also add a set of keys (similar to what Zulip's UX does here) for common actions - e.g. > for reply, e for edit, and so on, in addition to the arrow-based selection?

@ajbura
Copy link
Member
ajbura commented Jul 12, 2022

pressing up highlighted the last message that was sent in the room

@exodrifter Will it highlight all messages or just the one sent by user?

8000
@deanveloper
Copy link
Contributor

I don't want to put words in their mouth, but I believe all messages. This can useful for other keybinds, such as R for replying, and D for deleting messages (since mods/admins can delete other people's messages).

@exodrifter
Copy link
Contributor

@ajbura Yes, we were imagining that it would cycle through all messages and not just your own, so you could use other keybindings as @deanveloper correctly assumed.

@Tmpod
Copy link
Author
Tmpod commented Jul 12, 2022 via email

@ajbura
Copy link
Member
ajbura commented Jul 17, 2022

I think we are mixing two use cases here: First to quickly edit last sent message and second general keyboard navigation in timeline.

For editing the last sent message, Up arrow seems to be most commonly used and most app only allow to edit only last message, which make sense as most of the time people only want to edit just last message.

For the timeline navigation, the timeline scroll with up/down arrow works already and we can polish that to support reply, delete etc.

@Tmpod
Copy link
Author
Tmpod commented Aug 2, 2022 via email

greentore pushed a commit to greentore/greeny that referenced this issue Feb 13, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
RainbowTabitha pushed a commit to FurConnect/app that referenced this issue Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@exodrifter @deanveloper @blattersturm @ajbura @kfiven @Tmpod @BachoSeven and others
0