-
-
Notifications
You must be signed in to change notification settings - Fork 308
Upwards arrow on empty buffer should bring last message into edit mode #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In addition to this, I noticed these two flow things:
|
1. Yeah, I noticed that too. Best off as a separate issue like you suggested.
2. Yup, that would be neat to have. So if you wanted to edit the second to last message you could just quickly double tap the up arrow key.
|
Yeah, it's definitely a good idea to make it customisable!
|
This would go a long way of making Cinny more accessible to heavy keyboard users. Just wanted to add that when this gets implemented it would be nice to also have |
the way that slack and discord both work (which i really like) empty text box: up-arrow edits previous message another feature i really like that ties into this - pressing tab highlights the "send message" box, and using the up/down arrows navigate through messages. pressing |
I talked about this with a friend and we would like to throw our hat in the ring. We think it would be better if pressing up highlighted the last message that was sent in the room and allowed you to pick between any of the message options you normally get on mouse hover. This way, you could press up arrow until you get to the message you want, use the left and right arrow buttons to navigate between message actions, and use the enter key to do do that action. If we designed it this way, it would be nice to automatically select the edit button and place it in the middle so you would only need one keypress to pick either one of the other two options. This solves a few problems:
|
In this case, would it make sense to also add a set of keys (similar to what Zulip's UX does here) for common actions - e.g. > for reply, e for edit, and so on, in addition to the arrow-based selection? |
@exodrifter Will it highlight all messages or just the one sent by user? |
I don't want to put words in their mouth, but I believe all messages. This can useful for other keybinds, such as R for replying, and D for deleting messages (since mods/admins can delete other people's messages). |
@ajbura Yes, we were imagining that it would cycle through all messages and not just your own, so you could use other keybindings as @deanveloper correctly assumed. |
We could also have a distinction between "Up" and "Shift+Up" -- one could go
through every message and the other would skip others' messages.
|
I think we are mixing two use cases here: First to quickly edit last sent message and second general keyboard navigation in timeline. For editing the last sent message, Up arrow seems to be most commonly used and most app only allow to edit only last message, which make sense as most of the time people only want to edit just last message. For the timeline navigation, the timeline scroll with up/down arrow works already and we can polish that to support reply, delete etc. |
I think we are mixing two use cases here: First to quickly edit last sent
message and second general keyboard navigation in timeline.
I'd say we could not treat quickly editing your last message as a special
case and just have it as a timeline action. `Up``e` really isn't harder than
just `Up`, imo.
|
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Is your feature request related to a problem? Please describe.
Editing the last message sent to quickly fix a mistake is a bit of a hassle at the moment. I have to grab my mouse and click the edit button.
Describe the solution you'd like
Like in many other clients and platforms (like Discord, which you're trying to replicate) allow you to enter edit mode on that last message by clicking on the upwards arrow when the message buffer is empty. This should be implemented in Cinny.
Describe alternatives you've considered
Some other key could be used, but I haven't thought of anything else outside of that.
The text was updated successfully, but these errors were encountered: