[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hidden flag #36233

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add a hidden flag #36233

wants to merge 2 commits into from

Conversation

jschwinger233
Copy link
Member

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 28, 2024
@jschwinger233 jschwinger233 force-pushed the pr/gray/hidden-boot-id-flag branch 2 times, most recently from 62e6d83 to a900306 Compare November 29, 2024 05:06
@jschwinger233
Copy link
Member Author

/ci-ipsec-e2e

@jschwinger233
Copy link
Member Author

/ci-ipsec-e2e

@jschwinger233
Copy link
Member Author

/ci-ipsec-e2e

@jschwinger233
Copy link
Member Author

/ci-ipsec-upgrade

By default, Cilium agents read the boot ID from
/proc/sys/kernel/random/boot_id, which is shared among containers
running on the same host. This commit introduces a hidden flag for
specifying the boot ID filename. With this flag set to a different
location, containerized Cilium agents can avoid sharing the same boot
ID.

The previous implementation read /proc/sys/kernel/random/boot_id during
init(), which is no longer feasible because we now need to wait until
the daemon processes the flags. To address this, an initLocalBootID()
function has been introduced to replace init(). Additionally, a new
file, bootid_other.go, has been created to handle non-Linux systems.

Signed-off-by: gray <gray.liang@isovalent.com>
/var/run/cilium/ is mounted to cilium-agent pod via hostPath:

  volumeMounts:
  - mountPath: /var/run/cilium
    name: cilium-run
  volumes:
  - hostPath:
      path: /var/run/cilium
      type: DirectoryOrCreate
    name: cilium-run

By configuring /var/run/cilium/boot_id with a random uuid in Kind
containers, Cilium agents installed with the hidden flag
`boot-id-file=/var/run/cilium/boot_id` will use different boot IDs.

This fixes the CI issue that Cilium agents running locally in Kind
always shared the same boot ID.

Signed-off-by: gray <gray.liang@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant