-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a hidden flag #36233
Draft
jschwinger233
wants to merge
2
commits into
main
Choose a base branch
from
pr/gray/hidden-boot-id-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add a hidden flag #36233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Nov 28, 2024
jschwinger233
force-pushed
the
pr/gray/hidden-boot-id-flag
branch
2 times, most recently
from
November 29, 2024 05:06
62e6d83
to
a900306
Compare
/ci-ipsec-e2e |
jschwinger233
force-pushed
the
pr/gray/hidden-boot-id-flag
branch
from
November 29, 2024 07:48
24f9cf0
to
b3f8589
Compare
/ci-ipsec-e2e |
jschwinger233
force-pushed
the
pr/gray/hidden-boot-id-flag
branch
from
November 29, 2024 08:17
b3f8589
to
e4fe2cd
Compare
/ci-ipsec-e2e |
/ci-ipsec-upgrade |
By default, Cilium agents read the boot ID from /proc/sys/kernel/random/boot_id, which is shared among containers running on the same host. This commit introduces a hidden flag for specifying the boot ID filename. With this flag set to a different location, containerized Cilium agents can avoid sharing the same boot ID. The previous implementation read /proc/sys/kernel/random/boot_id during init(), which is no longer feasible because we now need to wait until the daemon processes the flags. To address this, an initLocalBootID() function has been introduced to replace init(). Additionally, a new file, bootid_other.go, has been created to handle non-Linux systems. Signed-off-by: gray <gray.liang@isovalent.com>
/var/run/cilium/ is mounted to cilium-agent pod via hostPath: volumeMounts: - mountPath: /var/run/cilium name: cilium-run volumes: - hostPath: path: /var/run/cilium type: DirectoryOrCreate name: cilium-run By configuring /var/run/cilium/boot_id with a random uuid in Kind containers, Cilium agents installed with the hidden flag `boot-id-file=/var/run/cilium/boot_id` will use different boot IDs. This fixes the CI issue that Cilium agents running locally in Kind always shared the same boot ID. Signed-off-by: gray <gray.liang@isovalent.com>
jschwinger233
force-pushed
the
pr/gray/hidden-boot-id-flag
branch
from
November 29, 2024 09:44
e4fe2cd
to
571536a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #issue-number