8000 After updating all toolbars were gone · Issue #340 · chrisgurney/obsidian-note-toolbar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

After updating all toolbars were gone #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JohannaHerbst opened this issue May 14, 2025 · 26 comments
Open

After updating all toolbars were gone #340

JohannaHerbst opened this issue May 14, 2025 · 26 comments
Assignees
@chrisgurney
Labels
bug Something isn't working the way it should, and the problem is reproducible fix released 🛠️ Fix should be available in the latest release help wanted Extra attention is needed

Comments

@JohannaHerbst
Copy link
JohannaHerbst commented May 14, 2025 •
edited
Loading

Hi,

after updating yesterday, all my toolbars were gone, except the toolbar-callouts. I took a look at note-toolbar's data.json file and my custom toolbar data was indeed missing. So I copied the contents of an older back-up data.json and replaced the new data.json with it to restore my toolbars.

It worked, but I guess, this is not how it should be done?

I have no idea why the update removed the toolbars.

Have a nice day
Johanna
@chrisgurney
Copy link
Owner
chrisgurney commented May 14, 2025 •
edited
Loading

@JohannaHerbst Oh my goodness, I'm so sorry to hear this. I haven't heard this happen to anybody else, so I'm very curious about your setup.

  1. Do you recall what version you upgraded from?
  2. Are you using a sync service between devices? If so, which one?

@JohannaHerbst
Copy link
Author
JohannaHerbst commented May 14, 2025 •
edited
Loading

All is fine, because I had the backup and now all toolbars work as expected again. I just wanted to make sure that overriding the data.json is ok, my knowledge about those things is rather limited.

Regarding your questions:

There had been two updates in the last days, isn't it? I've activated both, so it must have been the update from version 1.23.03 to version 1.23.04. Unless I didn't mentioned the missing toolbars beforehand, which is unlikely. However, it was not from any prior version.

I use a plugin called "Obsidian Plugin Update Tracker", which keeps me informed about updates and also helps with updating several plugins at once.

My Obsidian version is 1.8.10

The vault is not synced at the moment at all, nor it's settings.

All the best
Johanna

@chrisgurney
Copy link
Owner

@JohannaHerbst Thanks for the additional information. Very helpful.

Out of curiosity, had you enabled the Load settings changes setting?

Regarding your question:

I just wanted to make sure that overriding the data.json is ok

If you completely replaced the file -- versus a portion of it which wasn't copy/pasted correctly -- it should be fine!

@JohannaHerbst
Copy link
Author
JohannaHerbst commented May 14, 2025 •
edited
Loading

Out of curiosity, had you enabled the Load settings changes setting?

The option Load settings changes is/was disabled on my side.

@chrisgurney
Copy link
Owner
chrisgurney commented May 14, 2025 •
edited
Loading

I'll investigate.

Help wanted

If anybody else has experienced your toolbars disappearing after upgrading, please let me know!

Please mention:

  1. the versions you upgraded from + to
  2. whether the Load external settings option is enabled, and
  3. other plugins you're using.

@chrisgurney chrisgurney added the help wanted Extra attention is needed label May 14, 2025
@DaranC
Copy link
DaranC commented May 15, 2025 •
edited
Loading

Hi, so I think I had this happen to me today - I apologize in advance if my experience is not written in a helpful format.

I'm on a Mac. I do not use a sync service. I started up Obsidian, but my very large vault's pages appeared to be blank. I quit and restarted. After I quit, a system error modal briefly showed on my screen and had the words "JavaScript" and the word "origin." It closed thanks to my trigger finger, sorry. Went to settings for note toolbar and it congratulated me for updating to 1.22, though I think that was the version (1.22.06)I was already on... it was more like the app reverted to first-launch mode(?)

Unfortunately I do not have a back-up, but now that I'm aware of said feature, I will use it.

I am running a buttload of other plug-ins... .
Community plugins:
Admonition
Advanced Tables
BRAT
Dataview
Dice Roller
Fantasy Statblocks
Folder notes
Force note view mode
Homepage
Iconize
Initiative Tracker
Kanban
Leaflet
Markdown table checkboxes
Media Extended
Meta Bind
Neighbouring Files
Projects
QuickAdd
Second Window
Shortcut Launcher
Style Settings
Supercharged Links
Templater

It is probably worth mentioning that Fantasy Statblocks does a whole lot of frontmatter parsing whenever I restart, so... that may have also been involved.

@chrisgurney
Copy link
Owner
chrisgurney commented May 15, 2025 •
edited
Loading

@DaranC Thank you for sharing.

Just to confirm did you lose your toolbar configuration, and had to start over? If so, I'm sorry to hear that.

It doesn't sound like an issue relating to the plugin, but I'll add that datapoint to my list, just in case. Thank you.

@JohannaHerbst
Copy link
Author

Hello, forgot to mention, I'm also on a mac. Relating to the plugins above, these are the ones I have in common with DaranC:

  • BRAT
  • Dataview
  • Folder notes
  • Homepage
  • Iconize
  • Metabind
  • Neighbouring Files
  • QuickAdd
  • Style Settings
  • Supercharged Links
  • Templater

Do you want to know the others too? It's a really long list of 67 plugins 🫣...

If I can be of any help please let me know. Note Toolbar is a great plugin and I still hope this disappearing settings/toolbars is due to something strange related to my computer or whatever in my case.

Have a good day
Johanna

@JohannaHerbst
Copy link
Author

@DaranC

Unfortunately I do not have a back-up, but now that I'm aware of said feature, I will use it.

I use Local Backup for this purpose, which automates the back-up process. I'd recommend it.

@chrisgurney
Copy link
Owner
chrisgurney commented May 16, 2025 •
edited
Loading

@JohannaHerbst @DaranC What version of BRAT are you both using? Have you been using it for Note Toolbar?

(They recently made changes to how new releases are fetched, and am wondering if that might be at play here.)

@JohannaHerbst
Copy link
Author

I've BRAT Version: 1.1.6 (updated recently) but I don't use it for Note Toolbar.

@chrisgurney
Copy link
Owner
chrisgurney commented May 16, 2025 •
edited
Loading

@JohannaHerbst Was worth a look. Thanks.

@laktiv
Copy link
Contributor
laktiv commented May 16, 2025

Hi.
Unfortunately, I’ve faced similar issue. And my backup a bit old.
Update thru brat in second vault didn’t delete data.json.
If I need to share something, please let me know

@chrisgurney chrisgurney added the bug Something isn't working the way it should, and the problem is reproducible label May 16, 2025
@chrisgurney
Copy link
Owner
chrisgurney commented May 16, 2025 •
edited
Loading

@laktiv Sorry to hear. What versions of Note Toolbar did you upgrade from → to?

@chrisgurney
Copy link
Owner
chrisgurney commented May 16, 2025 •
edited
Loading

@JohannaHerbst @laktiv @DaranC

⚠️ I've released a new version v1.23.05 where I've removed the setting that was possibly causing this issue, even if you weren't using it.

Please let me know if any data loss continues to occur after this update.

Notes:

  • This is the theory I'm working with at the moment, as I haven't made any other changes recently that affect loading/saving of plugin settings.
  • Thank you all for sharing your experiences. And sorry again for losing any configuration you were unable to backup!
  • FYI in the Gallery there's an item called Backup Note Toolbar config that makes a date-stamped copy of the plugin's data.json into your vault, that may be helpful if you're not backing up your vault/settings regularly otherwise.

@JohannaHerbst
8000 Copy link
Author

Hi, I just updated Note-Toolbar to the new version (v1.23.05) and (after restarting Obsidian) everything looks fine, as far as I can tell by now. All toolbars are intact and working.

Thanks for the tipp about the gallery item that back-ups the config file. I wasn't aware of that but had been looking for that option before, only in the app's settings not in the gallery. I've instantly integrated that item in one of my toolbars :-)

Thank you also for your superb plugin and all the best!

@DaranC
Copy link
DaranC commented May 16, 2025 •
edited by chrisgurney
Loading

@DaranC Thank you for sharing.

Just to confirm did you lose your toolbar configuration, and had to start over? If so, I'm sorry to hear that.

It doesn't sound like an issue relating to the plugin, but I'll add that datapoint to my list, just in case. Thank you.

Image Yup, had to start over... but I just built it back better. What your plugin adds to my vault easily justifies the rebuild, no worries. I updated to the new version and restarted Obsidian and did not get my old toolbars back... but having created a new toolbar, (and a bunch of other progress and updates, etc.,) I'm guessing I may have overwritten old data at some point / it had no old data to retrieve(?) Regardless, I really only had one old toolbar that I used, and its usefulness has been replaced by the new one - so if I'm enough of an outlier that you're just trying to solve my specific issue, consider it solved :-) Thank you for your excellent plugin and user-care!

@chrisgurney
Copy link
Owner
chrisgurney commented May 16, 2025 •
edited
Loading

@DaranC

Regardless, I really only had one old toolbar that I used, and its usefulness has been replaced by the new one - so if I'm enough of an outlier that you're just trying to solve my specific issue, consider it solved :-) Thank you for your excellent plugin and user-care!

Good to hear, and thank you!

Out of curiousity how did you colorize certain toolbar items? Via a CSS snippet that targeted those item's IDs?

@DaranC
Copy link
DaranC commented May 16, 2025

@DaranC

Regardless, I really only had one old toolbar that I used, and its usefulness has been replaced by the new one - so if I'm enough of an outlier that you're just trying to solve my specific issue, consider it solved :-) Thank you for your excellent plugin and user-care!

Good to hear, and thank you!

Out of curiousity how did you colorize certain toolbar items? Via a CSS snippet that targeted those item's IDs?

Yes, sort of.. I tried targeting their IDs but could not figure out the syntax... so I targeted the class associated with the SVGs themselves. Not recommended because any other use of these icons would then be colored as well, lol... I just don't end up using these anywhere else, so this works for me. :) If you get the syntax right for targeting IDs, please let me know!

.lucide-castle, .lucide-trees {
color:#00ff00;
}

@laktiv
Copy link
Contributor
laktiv commented May 16, 2025

Sorry to hear. What versions of Note Toolbar did you upgrade from → to?

5 days old beta to 1.23.04

@laktiv
Copy link
Contributor
laktiv commented May 16, 2025

⚠️ I've released a new version v1.23.05 where I've removed the setting that was possibly causing this issue, even if you weren't using it.

Please let me know if any data loss continues to occur after this update.

Notes:

  • This is the theory I'm working with at the moment, as I haven't made any other changes recently that affect loading/saving of plugin settings.
  • Thank you all for sharing your experiences. And sorry again for losing any configuration you were unable to backup!
  • FYI in the Gallery there's an item called Backup Note Toolbar config that makes a date-stamped copy of the plugin's data.json into your vault, that may be helpful if you're not backing up your vault/settings regularly otherwise.

Updated. No issues.
Backed up – let it serve as the second copy. By the way, to restore, should I replace the file? Is partial recovery not possible?

PS: It happens; it's not your fault. Thank you for your quick response.

@laktiv
Copy link
Contributor
laktiv commented May 16, 2025

Not recommended because any other use of these icons would then be colored as well, lol... I just don't end up using these anywhere else, so this works for me. :) If you get the syntax right for targeting IDs, please let me know!

No IDs yet. Some possible variations.

  1. Target all icons in NTB panels. Example - rash bin will be red.
:is(.note-toolbar-menu .menu-item-icon, [data-callout=note-toolbar]) svg {
    &.lucide-trash-2 { color: var(--color-red); }
}
  1. Target specific toolbar by location/id/name. It will affect a specific toolbar or, any toolbar positioned, or toolbars with settings elements as buttons, or with css class
.cg-note-toolbar-container[id="3bc6b5e8-5f56-4c24-9647-769da4eb866f"][data-name="Toolbar"][data-tbar-position="top"][data-csstheme="CSSCLASS"] {
  .cg-note-toolbar-callout {...}
}

Extra example - you could target by other conditions, like opened file etc. Code for coloring pin icon only in pinned tab

.workspace-tab-header:has(.mod-pinned) + .workspace-leaf,
.workspace-tab-header-container:has(.is-active .mod-pinned) + .workspace-tab-container {
  .cg-note-toolbar-callout .external-link[aria-label="Pin tab"] svg {
	-webkit-mask-image: var(--icon-pin-off); /* url("data:image/svg+xml,%3Csvg....) */
	background-color: var(--color-accent);
}

Image

@chrisgurney
Copy link
Owner

@laktiv

By the way, to restore, should I replace the file? Is partial recovery not possible?

I would say it's risky to partially restore the data.json (due to copy/paste missing something), and would suggest completely replacing the file with a backup.

@laktiv
Copy link
Contributor
laktiv commented May 16, 2025

I would say it's risky to partially restore the data.json (due to copy/paste missing something), and would suggest completely replacing the file with a backup.

I see. Thank you.

@chrisgurney chrisgurney added the fix released 🛠️ Fix should be available in the latest release label May 20, 2025
@chrisgurney chrisgurney self-assigned this May 20, 2025
@chrisgurney
Copy link
Owner

Closing this issue, but will reopen pending further reports of this problem.

@chrisgurney chrisgurney reopened this May 29, 2025
@chrisgurney
Copy link
Owner

Received this issue via the feedback form on May 28th. Will update as I get additional information.

Note Toolbar just updated and I lost all of my toolbars. I didn't think to save a copy of it so I've lost a lot of config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisgurney chrisgurney

Labels
bug Something isn't working the way it should, and the problem is reproducible fix released 🛠️ Fix should be available in the latest release help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@laktiv @DaranC @chrisgurney @JohannaHerbst
0