[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bincode 2.0.0 support #1586

Open
ashokspeelyaal opened this issue Jun 4, 2024 · 2 comments
Open

Bincode 2.0.0 support #1586

ashokspeelyaal opened this issue Jun 4, 2024 · 2 comments

Comments

@ashokspeelyaal
Copy link

We use bincode for serializationand store bin files, then deserialize for data access.
We try to upgrade to bincode 2.0.0-rc.3, however from bincode 2.0.0+ needs Encode, Decode traits to be implemented.

the trait `Encode` is not implemented for `chrono::DateTime<Utc>`

Any suggestions or workarounds?
@djc
Copy link
Member
djc commented Jun 4, 2024 •
edited
Loading

It looks like bincode 2 might have some support for serde compatibility using Compat/BorrowCompat macros? I'm not convinced yet that we want to add a bincode 2 dependency in order to support their custom traits, especially while there isn't even a GA release.

@ashokspeelyaal
Copy link
Author

Sure, I am already checking Compat/BorrowCompat.

But I recommend at least to start thinking about it as it is not anymore in beta and in rc.3 already, so I don't think there will be design level changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djc @ashokspeelyaal