8000 Package uninstall failure error not providing error details. · Issue #429 · chocolatey/ChocolateyGUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Package uninstall failure error not providing error details. #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andi3 opened this issue Apr 12, 2017 · 4 comments
Open

Package uninstall failure error not providing error details. #429

andi3 opened this issue Apr 12, 2017 · 4 comments
Labels
0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint Bug Issues where something has happened which was not expected or intended Up for Grabs Issues that are available by the community to work on
Milestone
2.2.0

Comments

@andi3
Copy link
andi3 commented Apr 12, 2017 •
edited by corbob
Loading

What You Are Seeing?

When uninstalling a package fails, the results do not include any actionable information.

In version 0.14.0-unstable0245:

chocolatey

In version 1.1.0:
2022-09-30_10-21-00

What is Expected?

Some sort of error output, or an indication that there was no information.

How Did You Get This To Happen? (Steps to Reproduce)

  1. choco install putty.portable
  2. Launch Chocolatey GUI and verify that putty.portable is showing as installed.
  3. choco uninstall putty.portable
  4. In Chocolatey GUI, find putty.portable and attempt to uninstall

Additional Details

The code to generate this message is right here:

ChocolateyGUI/Source/ChocolateyGui.Common.Windows/ViewModels/Items/PackageViewModel.cs

Lines 533 to 538 in 1595d27

var message = L(
nameof(Resources.ChocolateyRemotePackageService_UninstallFailedMessage),
Id,
Version,
string.Join("\n", result.Messages),
exceptionMessage);

System Details

N/A

Output Log

None at this time.
@corbob
Copy link
Member
corbob commented Sep 30, 2022

Thanks for reporting this! I've just verified that this appears to be fixed:
2022-09-30_10-21-00

@corbob corbob closed this as completed Sep 30, 2022
@corbob corbob reopened this Sep 30, 2022
@corbob corbob changed the title Error not shown correctly Package uninstall failure error not providing error details. Sep 30, 2022
@corbob
Copy link
Member
corbob commented Sep 30, 2022 •
edited
Loading

Thanks for the initial report @andi3. After some thought, I've reopened this and updated the description with our new Issue Template and expanded on what the current issue is (we don't actually output anything if there are no messages or exceptions).

Also marking it as Up for grabs. A good first pass at this may be to check if the messages and/or exception are empty, and provide a string like "Unable to determine error" in their place.

@corbob corbob added Bug Issues where something has happened which was not expected or intended 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels Sep 30, 2022
@corbob corbob added this to the Future milestone Sep 30, 2022
@corbob corbob added the Up for Grabs Issues that are available by the community to work on label Sep 30, 2022
@pauby pauby mentioned this issue Apr 16, 2024
Open
2 tasks
@pauby
Copy link
Member
9C62 pauby commented Apr 16, 2024

@corbob is this not related to recent work on providing error details from the log?

@corbob
Copy link
Member
corbob commented Apr 16, 2024

@pauby Although at first glance, it looks like it, I can say that it's not solved by it. I opened up the debugger, and it would seem in the scenario explicitly mentioned here, there are zero log messages being picked up by the log interceptor. Almost like #998, but it's empty even on the first run. It's possible that the UninstallPackage method isn't setting up the log the same as the InstallPackage method is, but that would require more investigation than the few minutes I gave it stepping through the debugger.

@gep13 gep13 modified the milestones: Future, 2.2.0 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint Bug Issues where something has happened which was not expected or intended Up for Grabs Issues that are available by the community to work on
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
4 participants
@gep13 @andi3 @pauby @corbob
0