-
Notifications
You must be signed in to change notification settings - Fork 391
(totalcommander) Install fails, adds trailing blank to path #2630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for raising this issue! The packages within this repository are maintained by a small team of volunteer Community Maintainers, in their own time. Their time, like yours is important. Please help them by not wasting it. This is a community repository where the expectation is that everybody will get involved by raising pull requests to fix problems they find. This will also allow that problem to be fixed more quickly as you don't have to wait for a member of the Community Maintainer Team to pick it up. If you are unable to fix the issue yourself, the Community Maintainers Team will look at it when time allows. There are no service level agreements, nor should there be any expectation on when people can resolve issues in their own time. A few dos and don'ts:
Thank you. |
Looking at the log, this looks like it is the installer of Total Commander that creates the necessary registry key while appending the space (and we take the value as is). There is still something we can do by trimming the value (possibly test as is before trimming the value though), as such I'll mark this issue as an up for grabs (should be fairly easy to implement). |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Please do not add a comment to circumvent automatic closure unless you plan to help move it forward. |
Dear contributor, As this issue seems to have been inactive for quite some time now, I've automatically closed it. |
Checklist
Chocolatey Version
2.4.2
Chocolatey License
None
Package Version
11.51.0
Current Behaviour
Installation fails because the package does not recognize the correct install path.
The COMMANDER_PATH variable is set to the value "C:\Program Files\Total Commander" before the upgrade.
The installation scripts prints the following message:
Please not the trailing blank at the end of the path "C:\Program Files\Total Commander " which should not be there!
Even if I add the parameter
--params '/InstallPath="%ProgramFiles%\Total Commander"'
(no trailing blank) to the installation it fails with exactly the same message as above. Unsetting the COMMANDER_PATH variable before the installation had the same result. The windows registry does not contain any paths with the trialing blank, so the install script itself seems to be buggy.Expected Behaviour
It should either use the correct path from the
COMMANDER_PATH
variable when it exists (without adding a trailing blank) or it should use the/InstallPath
parameter correctly.Steps To Reproduce
choco upgrade totalcommander
Environment
Chocolatey Log
Anything else?
No response
The text was updated successfully, but these errors were encountered: