8000 Does not work on terminal-link · Issue #28 · chalk/ansi-regex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Does not work on terminal-link #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LitoMore opened this issue Feb 20, 2019 · 2 comments
Closed

Does not work on terminal-link #28

LitoMore opened this issue Feb 20, 2019 · 2 comments
Labels
bug help wanted

Comments

@LitoMore
Copy link
Contributor

This bug only appears on iTerm 2.

How to reproduce

const terminalLink = require('terminal-link');
const stripAnsi = require('strip-ansi');

const link = terminalLink('click', 'https://github.com', {fallback: text => text});

console.log(stripAnsi(link));

Expected ouput

click

Actual output

ttps://github.com/sindresorhusclick
@sindresorhus sindresorhus transferred this issue from chalk/strip-ansi Feb 20, 2019
@LitoMore
Copy link
Contributor Author
LitoMore commented Feb 20, 2019 •
edited
Loading

@sindresorhus Should we add the terminal link pattern to the patterns array if the terminal does not support terminal link?

@LitoMore LitoMore mentioned this issue Feb 20, 2019
Closed
@sindresorhus
Copy link
Member
sindresorhus commented Feb 20, 2019 •
edited
Loading

Yes, it should strip it no matter what. The string to strip might come from somewhere else where the terminal did support a terminal link.

@LitoMore LitoMore mentioned this issue Feb 22, 2019
Merged
sindresorhus pushed a commit that referenced this issue Mar 8, 2019
@LitoMore @sindresorhus
Support more escape types like links (#29)
96200bb 
Fixes #21
Fixes #28
This was referenced Mar 8, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @LitoMore