8000 Are you open to some new classes? · Issue #8 · cfpb/DOCter · GitHub

More Web Proxy on the site http://driver.im/

Are you open to some new classes? #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

himedlooff opened this issue Nov 21, 2013 · 2 comments

himedlooff commented

There are a few instances of directly styling all elements when you should probably use a class for example:

section:before {
    display: block; 
    content: ""; 
    height: 60px; 
    margin: -60px 0 0; 
}

...

header {
    width: 100%;
    border-top: 4px solid #2CB34A;
    border-bottom: 1px solid #BABBBD;
    background-color: #fff;
    position: fixed;
    top: 0;
    z-index: 99999;
    height: 3.625em;
}

Are you open to swapping some of these for class names?

Member

ascott1 commented

Totally open to it. All of the CSS was written in crunch mode when launching eRegs so I'm sure it needs a little love.

Author

himedlooff commented

Ok cool, good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0