8000 Comparing v1.2.3...v1.3.0 · cfobel/si-prefix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cfobel/si-prefix
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.3
Choose a base ref
...
head repository: cfobel/si-prefix
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.0
Choose a head ref
  • 12 commits
  • 15 files changed
  • 1 contributor

Commits on Jul 4, 2024

  1. build: modernize by migrating to pyproject.toml with setuptools_scm

    Prior to this commit, the project used `setup.cfg` and `versioneer` for version
    management. However, using versioneer is no longer considered best practice.
    
    In this commit, migrate the project to use `pyproject.toml` for build configuration,
    leveraging `setuptools_scm` for automatic versioning. This change aligns with
    [PEP 621][pep-621] standards and modernizes the project's packaging approach. The
    `pyproject.toml` file now contains essential metadata and configuration settings. This
    ensures that versioning is still managed dynamically based on SCM tags using
    `setuptools_scm`, whose [GitHub repo][setuptools-scm] "About" description states:
    
    > the blessed package to manage your versions by scm tags
    
    Specifically, the `setuptools_scm` package is [endorsed][pypa] by the Python Packaging
    Authority (PyPA), which is a working group that maintains many of the relevant projects
    in the Python packaging ecosystem, including setuptools.
    
    [pep-621]: https://peps.python.org/pep-0621/
    [setuptools-scm]: https://github.com/pypa/setuptools_scm
    [pypa]: https://packaging.python.org/guides/single-sourcing-package-version/#using-setuptools-scm
    cfobel committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    5f09aca View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    59c238c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba818af View commit details
    Browse the repository at this point in the history
  3. ci: add CI workflow for automated testing

    Prior to this commit, there was no automated CI workflow configured for the project,
    which meant that tests, linting, and code quality checks had to be run manually.  This
    lack of automation could lead to inconsistencies and human errors.
    
    In this commit, add a new CI workflow is using GitHub Actions. The workflow includes:
    - Run tests on push and pull requests to the main branch.
    - Run tests on multiple Python versions (3.7, 3.8, 3.9, 3.10).
    - Cache dependencies to speed up the workflow.
    - Lint the code with flake8.
    - Check code formatting with black.
    - Run tests with pytest and collect coverage reports.
    - Upload coverage reports to Codecov.
    cfobel committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    90d5f77 View commit details
    Browse the repository at this point in the history
  4. ci: only run the publish job on a GitHub release event

    Prior to this commit, an attempt was made to publish the built package for each "main"
    push or pull request. However, PyPI does not support dev snapshot versions
    since (originally posted by @dstufft [here][1]):
    
    > The `+something` namespace is explicitly disallowed on PyPI, because the
    > primary thing they are designed to solve is to give people modifying a library
    > a place to add their own versioning system on top of the upstream versioning,
    > without risking namespace collision (for instance, I might modify foo `5.7` and
    > change the version to `5.7+dstufft.fixedabug`.
    
    This lead to the errors like the following:
    
    ```
    Uploading si_prefix-0.1.dev1+gb83616b-py3-none-any.whl
    WARNING  Error during upload. Retry with the --verbose option for more details.
    ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
             The use of local versions in <Version('0.1.dev1+gb83616b')> is not
             allowed. See https://packaging.python.org/specifications/core-metadata
             for more information.
    ```
    
    In this commit, configure the `publish` job to _only_ run on releases. This should
    prevent dev snapshot versions from being published.
    
    [1]: pypi/legacy#731 (comment)
    cfobel committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7da5094 View commit details
    Browse the repository at this point in the history
  5. docs: apply black formatting

    cfobel committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5376f9f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a5d57e3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    64a5ac2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ea1f1c7 View commit details
    Browse the repository at this point in the history
  9. style: apply black formatting

    cfobel committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1bd0918 View commit details
    Browse the repository at this point in the history
  10. style: convert module attr comment docs to docstrings

    This is better supported by IDEs (e.g., vscode) and allows for a flake8 line length
    exception (i.e., `# noqa: E501`) to be applied.
    cfobel committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5340768 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #13 from cfobel/fix/build-add-python-3.12-compatib…

    …ility
    
    fix(build): add python 3.12 compatibility
    cfobel authored Jul 5, 2024
    Configuration menu
    Copy the full SHA
    86a6fb9 View commit details
    Browse the repository at this point in the history
Loading
0