-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitvavo editOrderWs deadlock #24188
Comments
Hello @apollace, Thanks for reporting it. We will take a look and get back to you. |
Hello @carlosmiei, thanks, if you find anything I would be happy to see what was the issue in the PR 👍 |
@apollace Managed to reproduce the issue on my end, working on a fix right now. |
@apollace can you please upgrade your ccxt version and try again? It should be working as expected now. |
Thanks I will have a look this afternoon |
Thanks for the fix, unluckily the client order id is not returned in the response in case of rejection. this makes the order stuck in case of rejection. from the doc page (https://docs.bitvavo.com/#tag/Frequently-asked-questions/Trading):
|
In addition the version 4.4.29 broke the rest API |
@apollace I tried adding a requestId/id but as you can see the value is not returned
|
@apollace Oh Ok it needs to be an int:
|
@apollace Ok found the issue with the clientorderId as well, going to fix that too |
@carlosmiei Sorry for the late response, I missed you comments. I will ask to improve the doc because it doesn't look to be clear enough. |
@apollace We haven't released yet, but we will do shortly |
@apollace We just released a new version 4.4.32. Can you please upgrade and try again? |
@carlosmiei Seems to work, I will let you know if I see more issues |
@carlosmiei I can confirm that this issue is not present anymore. Thanks for the help! |
Operating System
Debian 12
Programming Languages
JavaScript
CCXT Version
4.4.27
Description
Calling multiple times editOrderWs reliably generates a deadlock.
I tried to debug but I did not really understood the reason behind the deadlock.
Everything looks fine while debugging, the watch function inside looks ok, the state looks ok, there are no pending futures inside the client of the Exchange class but at the end of the watch function the result is a deadlock.
Can someone help me understanding what is going on?
Code
The text was updated successfully, but these errors were encountered: