Inferred vs declared return type namespace mismatch #841

amake · 2025-03-28T14:18:27Z

The following code:

module MyModule
  class Bar
    def initialize
      # empty
    end
  end

  class Baz
    # empty
  end

  class Foo1 < Bar
    class << self
      # This is an error
      #
      # @return [Foo1]
      def foo
        new
      end
    end
  end

  class Foo2 < Baz
    class << self
      # But this is not an error, and the only difference is whether the parent
      # class has an `initialize` method
      #
      # @return [Foo2]
      def foo
        new
      end
    end
  end
end

Gives the following error:

% solargraph typecheck --level typed tmp.rb
tmp.rb:17 - Declared return type MyModule::Foo1 does not match inferred type Foo1 for MyModule::Foo1.foo
1 problem found.

Changing line 17 to @return [MyModule::Foo1] resolves the issue, but it seems like that shouldn't be necessary or it should be required for line 28 (@return [Foo2]) as well.

The text was updated successfully, but these errors were encountered:

castwide · 2025-03-28T14:36:36Z

This bug is being addressed in #824. I expect to include the fix in a patch release soon.

castwide · 2025-03-29T07:08:06Z

Fix released in 0.53.3.

amake · 2025-03-30T12:14:38Z

Confirmed! Thanks!

amake closed this as completed Mar 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inferred vs declared return type namespace mismatch #841

Inferred vs declared return type namespace mismatch #841

Inferred vs declared return type namespace mismatch #841

Inferred vs declared return type namespace mismatch #841

Comments