8000 rename jaccard to containment · Issue #95 · czbiohub-sf/orpheum · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 17, 2023. It is now read-only.

rename jaccard to containment #95

Open
pranathivemuri opened this issue Oct 11, 2020 · 0 comments
Open

rename jaccard to containment #95

pranathivemuri opened this issue Oct 11, 2020 · 0 comments

Comments

@pranathivemuri
Copy link
Contributor

From Olga on PR #93 To keep things clean, in a future PR, I'd like to rename jaccard --> containment because after talking with @bluegenes I've realized it's not truly a Jaccard score. The denominator isn't the union of all k-mers total between the read's translation frame and the database, but the number of k-mers in that translation frame. So it's technically not accurate and someone who is really nitpicky about what Jaccard means would be annoyed with the naming.

would require renaming of jaccard threshold etc flags
would effect kmermaid, predict-orthologs pipelines

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant
0