qusion eats SIGINT and SIGTERM #6

edwintorok · 2011-04-27T14:25:03Z

If qusion gem is added, then 'rails server' no longer reacts to Ctrl-C and SIGTERM.
The culprit is this code in lib/qusion.rb:
def self.die_gracefully_on_signal
Signal.trap("INT") { graceful_stop }
Signal.trap("TERM") { graceful_stop }
end

def self.graceful_stop
EM.schedule do
@graceful_stop = true
AMQP.stop { EM.stop }
end
thread && thread.join
end

Adding some logging code shows that the join happens successfully, but you don't call the old handler!
Thus you shutdown the AMQP thingy, but leave the application running. You should probably invoke the old handler (that Signal.trap returned), to make sure that rails shuts down successfully.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

qusion eats SIGINT and SIGTERM #6

qusion eats SIGINT and SIGTERM #6

qusion eats SIGINT and SIGTERM #6

qusion eats SIGINT and SIGTERM #6

Comments