10000 Estimate Merkle update wu cost based on number of added+removed cells · Issue #719 · broxus/tycho · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Estimate Merkle update wu cost based on number of added+removed cells #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SmaGMan opened this issue May 2, 2025 · 0 comments
Open

Estimate Merkle update wu cost based on number of added+removed cells #719

SmaGMan opened this issue May 2, 2025 · 0 comments
Labels
C-collator Collator module P-medium Medium priority S-performance Severity: performance.
Milestone
040. Collator - i...

Comments

@SmaGMan
Copy link
Contributor
SmaGMan commented May 2, 2025

Currently, the Merkle update wu is estimated based on the number of changed accounts. Instead, the estimation should be based on the actual number of added and removed cells in the Merkle update.

There is a method MerkleUpdate::compute_removed_cells() that computes a map of removed cells. During this process, it also determines the new cells, but does not return them.

We need to:

  • Implement a new method that returns both added and removed cells.
  • Refactor the existing method to use this new one internally.
  • Use the result of new method to recalculate the Merkle update wu, based on the total number of added + removed cells.
@SmaGMan SmaGMan added C-collator Collator module S-performance Severity: performance. P-medium Medium priority labels May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-collator Collator module P-medium Medium priority S-performance Severity: performance.
Projects
None yet
Milestone
040. Collator - improvements 01
Development

No branches or pull requests
1 participant
@SmaGMan
0