8000 Unify the `min_processed_to` calculation logic · Issue #676 · broxus/tycho · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unify the min_processed_to calculation logic #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SmaGMan opened this issue Apr 16, 2025 · 0 comments
Open

Unify the min_processed_to calculation logic #676

SmaGMan opened this issue Apr 16, 2025 · 0 comments
Labels
C-collator Collator module P-low Low priority S-refactor
Milestone
040. Collator - i...

Comments

@SmaGMan
Copy link
Contributor
SmaGMan commented Apr 16, 2025

We use build_all_shards_processed_to_by_partitions() (code) and find_min_processed_to_by_shards() (code) helper methods to calculate cumulative stats ranges. We use a similar logic in calculate_min_internals_processed_to_for_shard() (code) when we looking for min processed to for exact shard to calculate diff tail length.

We can use build_all_shards_processed_to_by_partitions() and find_min_processed_to_by_shards() and then get min processed to for exact shard for diff tail length calculation.

We can move method calculate_min_internals_processed_to_for_shard to do_collate_tests.rs and check that updated algorithm produces the same result in test_calculate_min_processed_to_masterchain and test_calculate_min_processed_to_shard tests.
@SmaGMan SmaGMan added C-collator Collator module P-low Low priority S-refactor labels Apr 16, 2025
@SmaGMan SmaGMan added this to the Collator improvements 1 milestone Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-collator Collator module P-low Low priority S-refactor
Projects
None yet
Milestone
040. Collator - improvements 01
Development

No branches or pull requests
1 participant
@SmaGMan
0