8000 Analysis fails if git repo has trailing slash · Issue #18 · brianwarner/facade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Analysis fails if git repo has trailing slash #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brianwarner opened this issue Jun 30, 2017 · 1 comment
Closed

Analysis fails if git repo has trailing slash #18

brianwarner opened this issue Jun 30, 2017 · 1 comment
Labels
bug

Comments

@brianwarner
Copy link
Owner

When cloning a repo with a trailing slash, Facade can't find the .git directory. This is because cloning a repo like this:

git clone git://domain.com/git/reponame

puts the repo into a directory called reponame, but doing the same like this:

git clone git://domain.com/git/reponame/

puts the repo into reponame/reponame.

This can be fixed by trimming the trailing slash.
@brianwarner brianwarner added this to the v1.0.1 milestone Jun 30, 2017
brianwarner added a commit that referenced this issue Sep 19, 2017
@brianwarner
Fix for #18
9670913 
A repo with a trailing slash would fail, because everything to the right of the
last slash is used as the parent directory when cloning. If it wasn't there, it
wouldn't work.

Stripping trailing slashes now.

Signed-off-by: Brian Warner <brian@bdwarner.com>
@brianwarner brianwarner removed this from the v1.0.1 milestone Sep 19, 2017
@brianwarner
Copy link
Owner Author

Fixed in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
3C17 No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brianwarner
0