Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 1 commit
- 2 files changed
- 1 contributor
Commits on Oct 6, 2016
-
Adding the ability to skip tests that require the AllowAll identity p…
…rovider Conformance tests are useful in some running clusters however admin can't always want to disable authentication. The main thing this commit does is add a new optional regex for excluding tests. The TEST_ONLY logic was flipped to make it a little easier to read (and I don't think it was actually working before). Running with these tests skipped against the latest Origin 1.4 codebase: ------- Ran 115 of 564 Specs in 2097.700 seconds SUCCESS! -- 115 Passed | 0 Failed | 0 Pending | 449 Skipped PASS Ran 7 of 564 Specs in 162.981 seconds SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 557 Skipped PASS ------- Another important difference is the fact that the conformance tests are now run with the extended.test binary instead of with ginkgo. Ginkgo doesn't ship with the official builds of Origin or OpenShift Container platform and it seems like the differences between the two ways of running the tests are arbitrary. This allows someone to run the tests as follows: PARALLEL_NODES=1 KUBECONFIG=/etc/origin/master/admin.kubeconfig EXTENDEDTEST="/usr/libexec/atomic-openshift/extended.test" TEST_ONLY=true OPENSHIFT_SKIP_ALLOWALL_AUTH_TESTS=true ./test/extended/conformance.sh
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...master