8000 Claim Tracking · Issue #79 · bonsol-collective/bonsol · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Claim Tracking #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
austbot opened this issue Oct 28, 2024 · 2 comments
Open

Claim Tracking #79

austbot opened this issue Oct 28, 2024 · 2 comments

Comments

@austbot
Copy link
Contributor
austbot commented Oct 28, 2024

Missed claims currently just fall into a black hole and the prover never retries them if they hav expired. We need a way for profitable execution requests can be retried once the current claim has expired.
@augchan42
Copy link
Contributor

Let me check the claim handling code to verify if this is still accurate:

Read file: onchain/bonsol/src/actions/claim.rs

Looking at the code, this issue appears to still be accurate. Here's what happens with claims based on the code:

  1. When a claim is made, if the execution has expired (ca.expired is true), the code calls cleanup_execution_account and returns with just a message "Execution expired" (lines 115-119).

  2. The cleanup_execution_account function (from utilities.rs) just:

    • Reallocates the account to 1 byte
    • Sets the exit code
    • Refunds the remaining lamports to the requester

  3. There is no mechanism to:

    • Queue expired claims for retry
    • Track profitable execution requests that failed due to expiration
    • Allow provers to pick up expired claims for retry

This means that once a claim expires, it does indeed "fall into a black hole" as the statement suggests. The profitable execution requests are not preserved or made available for retry by other provers.

The issue could be particularly impactful for:

  1. High-value execution requests that expire
  2. Cases where network congestion or temporary issues cause claims to expire
  3. Scenarios where provers might want to retry previously failed claims

So yes, the statement is still accurate for the current codebase - there is no retry mechanism for expired claims, and profitable execution requests can be lost if their claims expire.

@githubsands githubsands mentioned this issue Mar 10, 2025
Open
@githubsands
Copy link
Member
githubsands commented Mar 11, 2025 •
edited
Loading

@augchan42 hey aug could we be mindful of the ai generated feedback in the issues?

@githubsands githubsands mentioned this issue Apr 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@austbot @augchan42 @githubsands
0