Mathstring conveniences for axis_labels and tick labels #11584
Conversation
|
Docs for the conveniences introduced in this PR are in: #11544 |
|
This pull request introduces 1 alert when merging ef40ee4 into ddecf31 - view on LGTM.com new alerts:
|
| def test_plaintext() -> None: | ||
| from bokeh.models import PlainText | ||
| test_plaintext = PlainText("$$sin(x)$$") | ||
| return test_plaintext |
There was a problem hiding this comment.
What is the advantage of making these fixtures? They seem like they could just be module-scope vars defined at the top of the test module (which is fine)
There was a problem hiding this comment.
I just followed the current design of the file to be honest.
|
A couple of comments, but also please make an issue regarding the special-casing for the following release (cc @mattpap ) |
|
This was unfinished, should not have been merged yet. |
|
@mattpap It's close enough, in my opinion, and there are other PRs waiting on it. The rest will have to be follow-on. Edit: Also, as a matter of policy, in the future, if you have changes you consider blocking please submit an actual review requesting changes to actually communicate that effectively. |
|
It's not in my opinion. Given that I was more involved in this work, I should have been asked for a go ahead before this was merged. Now it makes my problem to deal with any issues that this PR introduces. |
|
I've presented the solution: a Changes Requested review will clearly communicate a strong objection to merging. Otherwise, I'm trying to get a release out with the information I have in front of me. |
* working conveniences axis_labels and tick labels * fix line too long * remove tick labels not computed * add inline property to bokehjs * mathstring tests * mathstring unit tests * remove inline prop from TeX * do not expect python conversions of mathstrings * Fix docstring links * Refactor _use_mathjax * update utils.ts Co-authored-by: tcmetzger <39711796+tcmetzger@users.noreply.github.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Strings with MathJax default TeX delimiters are now converted into TeX object.
Bokeh's bundler will check for those delimiters and include
bokeh-mathjax.Discussion on bundler and finding mathstrings #11589