8000 add support for utf-8 · Issue #70 · blunderer/libroxml · GitHub

More Web Proxy on the site http://driver.im/

add support for utf-8 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

matkoniecz opened this issue May 11, 2016 · 1 comment

matkoniecz commented

There is no support for UTF-8 in libroxml for now.

baemhai commented

Until this issue is taken up in earnest, I would like to suggest improvement steps :

make the limitation to ASCII and thus 7-bit char input explicit, in docs and doxygen. What is considered _"minimum, easy-to-use" _ is not as intuitive today as it was a few years back.
while standards are not satisfied, libroxml could put in safeguards with little patches like this

--- a/src/roxml_parser.c
+++ b/src/roxml_parser.c
@@ -17,7 +17,7 @@
 #define ROXML_PARSER_NCELLS	256
 #define ROXML_PARSER_NCELLS_MAX	512
 
-#define ROXML_PARSER_ITEM(parser, item)	(parser + item)
+#define ROXML_PARSER_ITEM(parser, item)	(parser + (unsigned char)item)
 
 ROXML_INT int roxml_parser_multiple(roxml_parser_item_t *parser, char *chunk, void *data)
 {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0